Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 474283002: Update DT_RELA* fields when packing relocations with addends. (Closed)

Created:
6 years, 4 months ago by simonb (inactive)
Modified:
6 years, 4 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update DT_RELA* fields when packing relocations with addends. If the shared libary being packed uses relocations with addends, update DT_RELASZ and DT_RELACOUNT instead of DT_RELSZ and DT_RELCOUNT. Check DT_RELAENT instead of DT_RELENT. Update unit test data to match. BUG=385553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289950

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M tools/relocation_packer/src/elf_file.cc View 4 chunks +14 lines, -11 lines 1 comment Download
M tools/relocation_packer/test_data/elf_file_unittest_relocs_arm64_packed.so View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
simonb (inactive)
6 years, 4 months ago (2014-08-15 16:23:55 UTC) #1
rmcilroy
lgtm with an optional suggestions. https://codereview.chromium.org/474283002/diff/1/tools/relocation_packer/src/elf_file.cc File tools/relocation_packer/src/elf_file.cc (right): https://codereview.chromium.org/474283002/diff/1/tools/relocation_packer/src/elf_file.cc#newcode396 tools/relocation_packer/src/elf_file.cc:396: // Only one will ...
6 years, 4 months ago (2014-08-15 16:28:48 UTC) #2
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 4 months ago (2014-08-15 16:32:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/474283002/1
6 years, 4 months ago (2014-08-15 16:35:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-15 18:22:15 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:40:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 289950

Powered by Google App Engine
This is Rietveld 408576698