Issue 474273003: sync: Refactor bookmarks integration tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 474273003: sync: Refactor bookmarks integration tests

Created:
6 years, 4 months ago by rlarocque

Modified:
6 years, 4 months ago

Reviewers:

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

sync: Refactor bookmarks integration tests Updates the bookmarks integration test helpers to use BookmarkObserver, rather than the ProfileSyncServiceObserver-based status checking hooks. Refactors the two-client bookmark integration tests to use this new checker functionality instead of the old AwaitQuiescence() and AwaitGroupSyncCycleComplete() calls. Replaces a python test server legacy test with the help of the fake-server's new sync entity injection feature. Deletes a few enable/disable tests. BUG=97780, 95742

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+484 lines, -554 lines)			Patch
M	chrome/browser/sync/test/integration/bookmarks_helper.h	View		2 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/test/integration/bookmarks_helper.cc	View	1 2	8 chunks	+164 lines, -49 lines	0 comments	Download
M	chrome/browser/sync/test/integration/status_change_checker.h	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/status_change_checker.cc	View	1	1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/test/integration/sync_test.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/test/integration/sync_test.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc	View		65 chunks	+302 lines, -479 lines	0 comments	Download

Issue 474273003: sync: Refactor bookmarks integration tests

Description

Patch Set 1 #

Patch Set 2 : Use RunLoop for StatusChangeChecker #

Patch Set 3 : Use RunLoop for favicon wait #