Issue 474243003: DevTools: make eye dropper live (refresh on frame update).

Issue 474243003: DevTools: make eye dropper live (refresh on frame update). (Closed)

Created:
6 years, 4 months ago by pfeldman

Modified:
6 years, 4 months ago

Reviewers:
dgozman

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: make eye dropper live (refresh on frame update). BUG=404375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290258

Patch Set 4 : Review comments addressed. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -13 lines)			Patch
	M	content/browser/devtools/renderer_overrides_handler.h	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
	M	content/browser/devtools/renderer_overrides_handler.cc	View	1 2 3	9 chunks	+45 lines, -13 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dgozman

lgtm https://codereview.chromium.org/474243003/diff/40001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/474243003/diff/40001/content/browser/devtools/renderer_overrides_handler.cc#newcode205 content/browser/devtools/renderer_overrides_handler.cc:205: host_ = NULL; Let's clear last_cursor_x{y} and color_picker_frame_ ...

6 years, 4 months ago (2014-08-18 13:50:53 UTC) #3

pfeldman

https://codereview.chromium.org/474243003/diff/40001/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/474243003/diff/40001/content/browser/devtools/renderer_overrides_handler.cc#newcode205 content/browser/devtools/renderer_overrides_handler.cc:205: host_ = NULL; On 2014/08/18 13:50:52, dgozman wrote: > ...

6 years, 4 months ago (2014-08-18 14:20:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/474243003/60001

6 years, 4 months ago (2014-08-18 14:21:18 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-18 15:34:22 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 (60001) as 290258

Expand Messages | Collapse Messages