rebaseline_server: allow substring filtering for builder and test

rebaseline_server: allow substring filtering for builder and test

If the user clicks on a particular value for one of these fields, that field's
value will go into the filtering box (so you will only see results matching
that field value).

(SkipBuildbotRuns)

R=borenet@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12000

[epoger, 2013-10-27 05:41:07]

Ready for review at patchset 1.

[epoger, 2013-10-27 05:43:24]

If you want to play with the UI, you can do so at
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...

[bsalomon, 2013-10-28 13:19:23]

On 2013/10/27 05:43:24, epoger wrote:
> If you want to play with the UI, you can do so at
>
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...

Nice. That seems useful. It'd be great if it worked for config as well. In the
text filters a clear button would be handy rather than
select-the-text-and-delete. In the checkbox filters it'd be nice to have select
all and select none, and possibly invert current selection.

[borenet, 2013-10-28 17:33:51]

On 2013/10/28 13:19:23, bsalomon wrote:
> On 2013/10/27 05:43:24, epoger wrote:
> > If you want to play with the UI, you can do so at
> >
>
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...
> 
> Nice. That seems useful. It'd be great if it worked for config as well. In the
> text filters a clear button would be handy rather than
> select-the-text-and-delete. In the checkbox filters it'd be nice to have
select
> all and select none, and possibly invert current selection.

Code LGTM but I agree with Brian's suggestions.  I also wonder how easy it would
be to use regular expressions instead of just substrings, so I could do, for
example, "Android*Debug".

[epoger, 2013-10-29 03:25:51]

On 2013/10/28 13:19:23, bsalomon wrote:
> On 2013/10/27 05:43:24, epoger wrote:
> > If you want to play with the UI, you can do so at
> >
>
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...
> 
> Nice. That seems useful. It'd be great if it worked for config as well. In the
> text filters a clear button would be handy rather than
> select-the-text-and-delete. In the checkbox filters it'd be nice to have
select
> all and select none, and possibly invert current selection.

In patchset 2, I have fulfilled Brian's every wish (I think).  Check it out and
let me know.

[epoger, 2013-10-29 03:25:57]

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/view.html:49: For the text-filtered categories,
allow regular expression matching
On 2013/10/28 17:33:51, borenet wrote:
>  I also wonder how easy it would
> be to use regular expressions instead of just substrings, so I could do, for
> example, "Android*Debug".

For now, added a TODO here.  I think it could be a bit tricky performance-wise,
as noted here.

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/view.html:301: ng-click="(viewingTab != defaultTab)
|| setCategoryValueMatch(categoryName, result[categoryName])">
Added the (viewingTab != defaultTab) quasi-conditional ("only call the method if
viewingTab == defaultTab") so that clicking on results in the Hidden / Pending
Approval tabs don't mess up the Unfiled tab.

For the reason given in the comment I added just above, you can't use a real
conditional in these statements.

[borenet, 2013-10-29 13:56:53]

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/loader.js:303: $scope.toggleValueInSet(resultType,
$scope.hiddenResultTypes);
I'm confused about why you're using these toggle functions instead of just
adding and subtracting...

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/view.html:124: <button
ng-click="categoryValueMatch[category] = ''; updateResults()"
Why not use setCategoryValueMatch()?

[bsalomon, 2013-10-29 14:01:24]

On 2013/10/29 03:25:51, epoger wrote:
> On 2013/10/28 13:19:23, bsalomon wrote:
> > On 2013/10/27 05:43:24, epoger wrote:
> > > If you want to play with the UI, you can do so at
> > >
> >
>
http://wpgntat-ubiq141.hot.corp.google.com:8111/static/view.html?resultsToLoa...
> > 
> > Nice. That seems useful. It'd be great if it worked for config as well. In
the
> > text filters a clear button would be handy rather than
> > select-the-text-and-delete. In the checkbox filters it'd be nice to have
> select
> > all and select none, and possibly invert current selection.
> 
> In patchset 2, I have fulfilled Brian's every wish (I think).  Check it out
and
> let me know.

looks great!

[epoger, 2013-10-29 15:44:58]

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/loader.js:303: $scope.toggleValueInSet(resultType,
$scope.hiddenResultTypes);
On 2013/10/29 13:56:54, borenet wrote:
> I'm confused about why you're using these toggle functions instead of just
> adding and subtracting...

Because they're different data types.  Added a TODO.

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/47423002/diff/60001/gm/rebaseline_server/stat...
gm/rebaseline_server/static/view.html:124: <button
ng-click="categoryValueMatch[category] = ''; updateResults()"
On 2013/10/29 13:56:54, borenet wrote:
> Why not use setCategoryValueMatch()?

Done.

[borenet, 2013-10-29 15:49:01]

LGTM

[epoger, 2013-10-29 15:49:44]

Committed patchset #3 manually as r12000 (presubmit successful).