Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: LayoutTests/http/tests/serviceworker/unregister.html

Issue 474193002: Migrate some tests to use ServiceWorkerRegistration.unregister() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: forgot a file Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/serviceworker/unregister.html
diff --git a/LayoutTests/http/tests/serviceworker/unregister.html b/LayoutTests/http/tests/serviceworker/unregister.html
index 1aa8417543a7ff4ce558e81de1f925aba341e567..5917494d713d99a04acb108c678859b46e06dc0a 100644
--- a/LayoutTests/http/tests/serviceworker/unregister.html
+++ b/LayoutTests/http/tests/serviceworker/unregister.html
@@ -16,28 +16,35 @@ async_test(function(t) {
}, 'Unregistering out of origin');
async_test(function(t) {
- navigator.serviceWorker.unregister('/nothing-here/')
+ var scope = 'scope/unregister-twice';
nhiroki 2014/08/15 09:53:40 These should be 4-indents? https://sites.google.co
+ var registration;
+ navigator.serviceWorker.register('resources/empty-worker.js', {scope: scope})
+ .then(function(r) {
+ registration = r;
+ return registration.unregister();
+ })
+ .then(function() {
+ return registration.unregister();
+ })
.then(function(value) {
- assert_equals(value, undefined,
- 'unregistering with no existing registration should ' +
- 'succeed with no value');
- t.done();
- })
+ assert_equals(value, undefined,
+ 'unregistering twice should succeed with no value');
+ t.done();
+ })
.catch(unreached_rejection(t));
-}, 'Unregistering with no existing registration');
+}, 'Unregister twice');
async_test(function(t) {
- var scope = '/register-then-unregister/';
- navigator.serviceWorker.register(
- 'resources/empty-worker.js', {scope: scope})
- .then(function(worker) {
- return navigator.serviceWorker.unregister(scope);
- })
+ var scope = 'scope/successful-unregister/';
+ navigator.serviceWorker.register('resources/empty-worker.js', {scope: scope})
+ .then(function(registration) {
+ return registration.unregister();
+ })
.then(function(value) {
- assert_equals(value, undefined,
- 'successful unregistration should succeed with no value');
- t.done();
- })
+ assert_equals(value, undefined,
+ 'successful unregistration should succeed with no value');
+ t.done();
+ })
.catch(unreached_rejection(t));
}, 'Register then unregister');
@@ -64,5 +71,4 @@ async_test(function(t) {
})
.catch(unreached_rejection(t));
}, 'Unregistering with default scope');
-
</script>

Powered by Google App Engine
This is Rietveld 408576698