Migrate some tests to use ServiceWorkerRegistration.unregister()

Migrate some tests to use ServiceWorkerRegistration.unregister()

ServiceWorkerContainer.unregister() is going away but the change will be
done in steps. This patch updates some select tests focused on
unregistration to use the new unregister() function.

BUG=404064
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180354

[falken, 2014-08-15 08:30:12]

PTAL

[nhiroki, 2014-08-15 09:53:41]

Looks pretty good. nits only.

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/unregister-controller.html (right):

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-controller.html:61: return
registration.unregister(scope);
You don't have to pass |scope| to registration.unregister(). Can you remove it?
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#se...

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-controller.html:97: return
registration.unregister(scope);
ditto. |scope| is no longer necessary.

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html
(right):

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html:27:
return registration.unregister(scope);
ditto.

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/unregister-then-register.html (right):

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-then-register.html:51: return
registration.unregister(scope);
ditto.

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-then-register.html:85: return
registration.unregister(scope);
ditto.

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-then-register.html:121: return
registration.unregister(scope);
ditto.

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/unregister.html (right):

https://codereview.chromium.org/474193002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister.html:19: var scope =
'scope/unregister-twice';
These should be 4-indents?
https://sites.google.com/a/chromium.org/dev/blink/serviceworker/testing?pli=1...

[falken, 2014-08-15 10:02:54]

Thanks, revised the patch. PTAL.

[nhiroki, 2014-08-15 10:25:31]

lgtm

https://codereview.chromium.org/474193002/diff/40001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/unregister.html (right):

https://codereview.chromium.org/474193002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister.html:21:
navigator.serviceWorker.register('resources/empty-worker.js', {scope: scope})
Can you wrap at 80-columns?

https://codereview.chromium.org/474193002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister.html:55: return
wait_for_update(t, registration);
+4indents.

https://codereview.chromium.org/474193002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister.html:56: })
+2indents.

https://codereview.chromium.org/474193002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister.html:68: 'service worker
registered with default scope should be ' +
80-columns.

[falken, 2014-08-15 10:42:34]

Thanks! Addressed comments.

[falken, 2014-08-15 10:42:53]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-08-15 10:43:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/474193002/60001

[commit-bot: I haz the power, 2014-08-15 11:44:37]

Committed patchset #4 (60001) as 180354