Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 474183002: Cleanup namespace usage in Source/web/*.h (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, tzik, eric.carlson_apple.com, apavlov+blink_chromium.org, aandrey+blink_chromium.org, lushnikov+blink_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, philipj_slow, nhiroki, eustas+blink_chromium.org, paulirish+reviews_chromium.org, dcheng, gavinp+prerender_chromium.org, feature-media-reviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in Source/web/*.h - Merge multiple |namespace blink| blocks - Remove unnecessary blink:: prefix - Other minor style fixes. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -199 lines) Patch
M Source/web/BackForwardClientImpl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.h View 3 chunks +11 lines, -13 lines 0 comments Download
M Source/web/ColorChooserUIController.h View 2 chunks +6 lines, -10 lines 0 comments Download
M Source/web/CompositionUnderlineBuilder.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/web/CompositionUnderlineVectorBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextFeaturesClientImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/ContextMenuClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/DatabaseClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DragClientImpl.h View 1 chunk +8 lines, -7 lines 0 comments Download
M Source/web/EditorClientImpl.h View 1 chunk +5 lines, -8 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.h View 2 chunks +6 lines, -9 lines 0 comments Download
M Source/web/FindInPageCoordinates.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/IndexedDBClientImpl.h View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/web/LinkHighlight.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/MIDIClientProxy.h View 1 chunk +5 lines, -8 lines 0 comments Download
M Source/web/MediaKeysClientImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/NavigatorContentUtilsClientImpl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/PageOverlayList.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/web/PageScaleConstraintsSet.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/web/PageWidgetDelegate.h View 3 chunks +11 lines, -14 lines 0 comments Download
M Source/web/PrerendererClientImpl.h View 1 chunk +4 lines, -7 lines 0 comments Download
M Source/web/RemoteFrameClient.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/SpeechRecognitionClientProxy.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/web/UserMediaClientImpl.h View 1 chunk +7 lines, -10 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.h View 1 chunk +12 lines, -15 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.h View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/web/WorkerPermissionClient.h View 3 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Please review this.
6 years, 4 months ago (2014-08-15 08:38:08 UTC) #1
keishi
LGTM
6 years, 4 months ago (2014-08-18 06:08:07 UTC) #2
tkent
thank you!
6 years, 4 months ago (2014-08-18 06:09:15 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-18 06:09:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/474183002/1
6 years, 4 months ago (2014-08-18 06:09:40 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 06:13:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180427

Powered by Google App Engine
This is Rietveld 408576698