Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 474173002: IDL: Use IdlNullableType wrapper to represent nullable types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 97bafbfb65b4b7324b0b840b4103f2ef8e881237..7dae5031f71bb2027ad0b13204195ea0841b55a5 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -7408,13 +7408,14 @@ static void voidMethodDefaultFalseBooleanArgMethodCallback(const v8::FunctionCal
static void voidMethodDefaultNullableByteStringArgMethod(const v8::FunctionCallbackInfo<v8::Value>& info)
{
+ ExceptionState exceptionState(ExceptionState::ExecutionContext, "voidMethodDefaultNullableByteStringArg", "TestObject", info.Holder(), info.GetIsolate());
TestObject* impl = V8TestObject::toNative(info.Holder());
V8StringResource<TreatNullAsNullString> defaultStringArg;
{
v8::TryCatch block;
V8RethrowTryCatchScope rethrow(block);
if (!info[0]->IsUndefined()) {
- TONATIVE_VOID_INTERNAL(defaultStringArg, toByteString(info[0]));
+ TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultStringArg, toByteString(info[0], exceptionState), exceptionState);
Jens Widell 2014/08/15 07:13:49 This seems a correct change; there's only one toBy
} else {
defaultStringArg = nullptr;
}
« Source/bindings/scripts/v8_dictionary.py ('K') | « Source/bindings/scripts/v8_types.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698