Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 474163004: Exclude PolicyTest.FileURLBlacklist from DrMemory where it fails. (Closed)

Created:
6 years, 3 months ago by Jeffrey Yasskin
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Exclude PolicyTest.FileURLBlacklist from DrMemory where it fails. BUG=339240 TBR=joaodasilva@chromium.org NOTRY=true Committed: https://crrev.com/0ddb7f787dbc3e9b65d6fe55babe6a0bf3408e81 Cr-Commit-Position: refs/heads/master@{#291979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jeffrey Yasskin
The CQ bit was checked by jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 20:36:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/474163004/1
6 years, 3 months ago (2014-08-26 20:37:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 2d63f96aadc4febf65ead06514306e0b6c8a0599
6 years, 3 months ago (2014-08-26 20:39:01 UTC) #3
Joao da Silva
lgtm, thanks. Looks like there is some race in here the DrMemory triggers more consistently, ...
6 years, 3 months ago (2014-08-27 09:19:49 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:32 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ddb7f787dbc3e9b65d6fe55babe6a0bf3408e81
Cr-Commit-Position: refs/heads/master@{#291979}

Powered by Google App Engine
This is Rietveld 408576698