Revert 289715 "libvpx.gyp: Remove redundant sources."

Revert 289715 "libvpx.gyp: Remove redundant sources."

Not so redundant:

{standard input}: Assembler messages:
{standard input}:27: Error: can't open vpx_scale_asm_offsets.asm for reading: No such file or directory
make: *** [out/target/product/generic/obj/STATIC_LIBRARIES/third_party_libvpx_libvpx_gyp_intermediates/vp8_vpxyv12_copyframe_func_neon.o] Error 1
make: *** Waiting for unfinished jobs....
{standard input}: Assembler messages:
{standard input}:27: Error: can't open vpx_scale_asm_offsets.asm for reading: No such file or directory
make: *** [out/target/product/generic/obj/STATIC_LIBRARIES/third_party_libvpx_libvpx_gyp_intermediates/vp8_vpxyv12_copysrcframe_func_neon.o] Error 1
{standard input}: Assembler messages:
{standard input}:27: Error: can't open vpx_scale_asm_offsets.asm for reading: No such file or directory
make: *** [out/target/product/generic/obj/STATIC_LIBRARIES/third_party_libvpx_libvpx_gyp_intermediates/vp8_vpxyv12_extendframeborders_neon.o] Error 1
In file included from external/chromium_org/third_party/libvpx/source/libvpx/vp8/common/arm/armv6/idct_blk_v6.c:11:0:
external/chromium_org/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h:13:0: warning: "ARCH_ARM" redefined [enabled by default]
 #define ARCH_ARM 1
 ^
In file included from <command-line>:0:0:
./build/core/combo/include/arch/linux-arm/AndroidConfig.h:254:0: note: this is the location of the previous definition
 #define ARCH_ARM
 ^
In file included from external/chromium_org/third_party/libvpx/source/libvpx/vp8/common/alloccommon.c:12:0:
external/chromium_org/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h:13:0: warning: "ARCH_ARM" redefined [enabled by default]
 #define ARCH_ARM 1
 ^
In file included from <command-line>:0:0:
./build/core/combo/include/arch/linux-arm/AndroidConfig.h:254:0: note: this is the location of the previous definition
 #define ARCH_ARM
 ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
make: *** wait: No child processes.  Stop.

On the AOSP builder we still can't find the scale offsets without the extra sources. Reverting for now.

> libvpx.gyp: Remove redundant sources.
> 
> A typo that went unnoticed at the usage sites of process_outputs_as_sources
> (a missing 's' in outputs) resulted in the workaround of adding the output from
> the libvpx asm offsets step as an explicit source file.
> 
> R=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/469363004

TBR=tomfinegan@google.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289815

[Tom Finegan, 2014-08-15 06:02:55]

Committed patchset #1 manually as r289815 (tree was closed).

[Johann, 2014-08-15 15:17:28]

On 2014/08/15 06:02:55, Tom Finegan wrote:
> Committed patchset #1 manually as r289815 (tree was closed).

Is this the right place to revert this? The path is
trunk/deps/third_party/libvpx/libvpx.gyp where the original change was in the
DEPS branch and just libvpx.gyp. The auto-rule to CC people on the change also
didn't kick in.

[chromium-reviews, 2014-08-15 16:20:48]

I'll double check, but drover usually knows best.

--
Sent from tiny screen. Mistakes will be made.
On Aug 15, 2014 8:17 AM, <johannkoenig@google.com> wrote:

> On 2014/08/15 06:02:55, Tom Finegan wrote:
>
>> Committed patchset #1 manually as r289815 (tree was closed).
>>
>
> Is this the right place to revert this? The path is
> trunk/deps/third_party/libvpx/libvpx.gyp where the original change was in
> the
> DEPS branch and just libvpx.gyp. The auto-rule to CC people on the change
> also
> didn't kick in.
>
> https://codereview.chromium.org/474153002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.