Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 474143002: Rename some functions of which names contain 'WebCore.' (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, jamesr, dglazkov+blink, dcheng, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Rename some functions of which names contain 'WebCore.' - WebLocalFrameImpl::initializeWebCoreFrame - WebLocalFrameImpl::setWebCoreFrame - WebRemoteFrameImpl::initializeCoreFrame - WebRemoteFrameImpl::setWebCoreFrame - WebViewImpl::focusedCoreFrame - toWebCoreFrame - updateWebMouseEventFromWebCoreMouseEvent BUG=none TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -95 lines) Patch
M Source/web/ContextMenuClientImpl.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/web/RemoteFrameClient.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/web/WebFrame.cpp View 6 chunks +16 lines, -18 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 20 chunks +27 lines, -28 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Keishi, would you review this please?
6 years, 4 months ago (2014-08-15 07:10:02 UTC) #1
keishi
LGTM
6 years, 4 months ago (2014-08-15 07:24:08 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-15 07:43:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/474143002/1
6 years, 4 months ago (2014-08-15 07:44:02 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 07:47:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180337

Powered by Google App Engine
This is Rietveld 408576698