chrome/browser/ui/views/profiles/profile_chooser_view.cc - Issue 474123002: [Mac, Win] Don't allow blank spaces in profile names in the new avatar bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 474123002: [Mac, Win] Don't allow blank spaces in profile names in the new avatar bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use TrimWhitespace ftw Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('K') | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

index 7c3d6e45599ec459780301f5f70b40f511fd8e0c..1783a3ed35272d1bf38e172cc8f93279a5a6adf1 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

@@ -800,6 +800,7 @@ bool ProfileChooserView::HandleKeyEvent(views::Textfield* sender,

key_event.key_code() == ui::VKEY_TAB) {

// Pressing Tab/Enter commits the new profile name, unless it's empty.

base::string16 new_profile_name = name_textfield->text();

+ base::TrimWhitespace(new_profile_name, base::TRIM_ALL, &new_profile_name);

if (new_profile_name.empty())

return true;

« chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('K') | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm ('k') | no next file » | no next file with comments »