[Mac, Win] Don't allow blank spaces in profile names in the new avatar bubble.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/first_run/first_run.h"
@@ skipping 782 matching lines @@
 bool ProfileChooserView::HandleKeyEvent(views::Textfield* sender,
                                         const ui::KeyEvent& key_event) {
   views::Textfield* name_textfield =
       current_profile_name_->profile_name_textfield();
   DCHECK(sender == name_textfield);
 
   if (key_event.key_code() == ui::VKEY_RETURN ||
       key_event.key_code() == ui::VKEY_TAB) {
     // Pressing Tab/Enter commits the new profile name, unless it's empty.
     base::string16 new_profile_name = name_textfield->text();
+    base::TrimString(new_profile_name, base::ASCIIToUTF16(" "),

[sky, 2014/08/15 04:38:41]

Might it be possible to get other characters in the name you don't want by way
of pasting? I'm wondering if this should trim all whitespace.

[noms (inactive), 2014/08/15 13:32:41]

But if you paste it in, isn't it still in the text() of the textfield? Do you
mean trimming \t and \n?

[sky, 2014/08/15 19:28:37]

Exactly.

+        &new_profile_name);
     if (new_profile_name.empty())
       return true;
 
     const AvatarMenu::Item& active_item = avatar_menu_->GetItemAt(
         avatar_menu_->GetActiveProfileIndex());
     Profile* profile = g_browser_process->profile_manager()->GetProfile(
         active_item.profile_path);
     DCHECK(profile);
 
     if (profile->IsSupervised())
@@ skipping 684 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }