Chromium Code Reviews

Issue 474053002: UMA log NTP loading time separately for local, google and other NTPs. (Closed)

Created:
6 years, 4 months ago by beaudoin
Modified:
6 years, 4 months ago
Reviewers:
Alexei Svitkine (slow), Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Mathieu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Log NTP loading time separately for local, Google and other NTPs. We currently use the same UMA metric to log the loading time of different kinds of NTP: - The local NTP - The Google app-cached NTP - NTP from other providers This CL separates these in three UMA metric using histogram suffixes. In addition, this CL brings back the Tab.NewTab* UMA metrics to the public histograms.xml in accordance with the practice that metrics in the public chromium repository should be in the public histograms.xml. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289946

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+64 lines, -3 lines)
M chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +13 lines, -1 line 0 comments
M tools/metrics/histograms/histograms.xml View 5 chunks +51 lines, -2 lines 1 comment

Messages

Total messages: 6 (0 generated)
beaudoin
Jered: That's a small CL cleaning up a UMA metric that I'm hoping to land ...
6 years, 4 months ago (2014-08-15 14:10:38 UTC) #1
Jered
On 2014/08/15 14:10:38, beaudoin wrote: > Jered: That's a small CL cleaning up a UMA ...
6 years, 4 months ago (2014-08-15 14:53:16 UTC) #2
Alexei Svitkine (slow)
lgtm, stamping since the branch point is so soon, but in the future it's better ...
6 years, 4 months ago (2014-08-15 14:59:43 UTC) #3
beaudoin
The CQ bit was checked by beaudoin@chromium.org
6 years, 4 months ago (2014-08-15 15:21:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/474053002/20001
6 years, 4 months ago (2014-08-15 15:23:16 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:31:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289946

Powered by Google App Engine