[chromedriver] Update run_buildbot_steps.py to work with git hashes

[chromedriver] Update run_buildbot_steps.py to work with git hashes

BUG=

Committed: https://crrev.com/b3d34a4cb8cc791ee07cd261a8123e88b110497c
Cr-Commit-Position: refs/heads/master@{#291942}

[samuong, 2014-08-25 20:27:26]

The Windows and Mac bots are failing because run_buildbot_steps.py is now being
called with a git hash instead of an svn revision. This CL converts the git hash
to a commit position if necessary, and uses it in place of the svn revision.
This means that our builds will continue to be archived by (commit position)
numbers, not git hashes.

[stgao, 2014-08-25 20:41:27]

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
File chrome/test/chromedriver/run_buildbot_steps.py (right):

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/run_buildbot_steps.py:415: util.PrintAndFlush('HTTP
Error %d' % error.getcode())
Why no return?

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/run_buildbot_steps.py:498: commit_position = None
In this case, I think we should fail the test. Because we don't know which
commit position we should wait for the snapshot, right?

[samuong, 2014-08-25 20:51:11]

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
File chrome/test/chromedriver/run_buildbot_steps.py (right):

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/run_buildbot_steps.py:415: util.PrintAndFlush('HTTP
Error %d' % error.getcode())
On 2014/08/25 20:41:27, Shuotao wrote:
> Why no return?

I'm not sure. I was blindly copying and pasting code from
_GetCommitPositionFromGitHash(), which didn't have a return there either. Looks
like this was an existing bug, so I've fixed both functions.

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/run_buildbot_steps.py:498: commit_position = None
On 2014/08/25 20:41:27, Shuotao wrote:
> In this case, I think we should fail the test. Because we don't know which
> commit position we should wait for the snapshot, right?

I was trying to maintain the script's original behavior. There's a case where if
the platform is android and --update-log is not passed, we're allowed to have no
--revision.

In this case it will download the prebuilt chromedriver and test it against the
chrome build that is installed on the device (so there's no snapshot to wait
for).

If we're doing a non-android build, there are still checks to make sure that a
revision is supplied.

[stgao, 2014-08-25 23:17:12]

lgtm

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
File chrome/test/chromedriver/run_buildbot_steps.py (right):

https://codereview.chromium.org/474013006/diff/20001/chrome/test/chromedriver...
chrome/test/chromedriver/run_buildbot_steps.py:498: commit_position = None
On 2014/08/25 20:51:11, samuong wrote:
> On 2014/08/25 20:41:27, Shuotao wrote:
> > In this case, I think we should fail the test. Because we don't know which
> > commit position we should wait for the snapshot, right?
> 
> I was trying to maintain the script's original behavior. There's a case where
if
> the platform is android and --update-log is not passed, we're allowed to have
no
> --revision.
> 
> In this case it will download the prebuilt chromedriver and test it against
the
> chrome build that is installed on the device (so there's no snapshot to wait
> for).
> 
> If we're doing a non-android build, there are still checks to make sure that a
> revision is supplied.

OK. Sound good.

[samuong, 2014-08-25 23:22:38]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2014-08-25 23:23:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/samuong@chromium.org/474013006/40001

[commit-bot: I haz the power, 2014-08-26 02:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 02:14:37]

Failed to commit the patch.

[samuong, 2014-08-26 17:05:07]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:06:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/samuong@chromium.org/474013006/60001

[commit-bot: I haz the power, 2014-08-26 18:18:27]

Committed patchset #4 (60001) as 2c42d3031938e4c88d1a961a760dd1070be2f493

[commit-bot: I haz the power, 2014-09-10 02:44:07]

Patchset 4 (id:??) landed as
https://crrev.com/b3d34a4cb8cc791ee07cd261a8123e88b110497c
Cr-Commit-Position: refs/heads/master@{#291942}