Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 473953004: Revert of Multiprofile security: Show a warning messagebox when desktop casting/sharing is turned on upon user (Closed)

Created:
6 years, 4 months ago by dewittj
Modified:
6 years, 4 months ago
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Multiprofile security: Show a warning messagebox when desktop casting/sharing is turned on upon user (patchset #3 of https://codereview.chromium.org/496563002/) Reason for revert: Broke Linux ChromiumOS Tests on waterfall: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47585 Original issue's description: > Multiprofile security: Show a warning messagebox when desktop > casting/sharing is turned on upon user switch > > Purpose of this change: > > Asks the user with a system modal dialog box if he wants to > turn off screen sharing/screen casting and then switch users > or abort switching users. > > BUG=353170 > TEST=TrySwitchingUserTest.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291152 TBR=jennyz@chromium.org,jamescook@chromium.org,skuhne@chromium.org NOTREECHECKS=true NOTRY=true BUG=353170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -514 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/ash_chromeos_strings.grdp View 1 chunk +0 lines, -14 lines 0 comments Download
M ash/system/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ash/system/chromeos/multi_user/user_switch_util.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ash/system/chromeos/multi_user/user_switch_util.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D ash/system/chromeos/multi_user/user_switch_util_unittest.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M ash/system/tray/system_tray.h View 3 chunks +0 lines, -8 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ash/system/user/tray_user_separator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/system/user/user_view.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 4 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dewittj
6 years, 4 months ago (2014-08-21 20:12:12 UTC) #1
Created Revert of Multiprofile security: Show a warning messagebox when desktop
casting/sharing is turned on upon user

Powered by Google App Engine
This is Rietveld 408576698