Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2784)

Unified Diff: content/renderer/render_view_impl.cc

Issue 473953002: Defer scroll offset change notification to browser (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 46b4f74666d5a47078ad74f16adc7ce92c8c8883..af6a09b68f9c71c001b2f2230929a480e200d1ed 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -718,6 +718,7 @@ RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
top_controls_constraints_(cc::BOTH),
#endif
has_scrolled_focused_editable_node_into_rect_(false),
+ has_scrolled_main_frame_(false),
speech_recognition_dispatcher_(NULL),
browser_plugin_manager_(NULL),
devtools_agent_(NULL),
@@ -2504,15 +2505,19 @@ BrowserPluginManager* RenderViewImpl::GetBrowserPluginManager() {
return browser_plugin_manager_.get();
}
-void RenderViewImpl::UpdateScrollState(WebFrame* frame) {
- Send(new ViewHostMsg_DidChangeScrollOffset(routing_id_));
+void RenderViewImpl::didCommitAndDrawCompositorFrame() {
+ RenderWidget::didCommitAndDrawCompositorFrame();
+ if (has_scrolled_main_frame_) {
+ has_scrolled_main_frame_ = false;
+ Send(new ViewHostMsg_DidChangeScrollOffset(routing_id_));
+ }
}
void RenderViewImpl::didChangeScrollOffset(WebLocalFrame* frame) {
StartNavStateSyncTimerIfNecessary();
if (webview()->mainFrame() == frame)
- UpdateScrollState(frame);
+ has_scrolled_main_frame_ = true;
FOR_EACH_OBSERVER(
RenderViewObserver, observers_, DidChangeScrollOffset(frame));
@@ -3340,7 +3345,7 @@ void RenderViewImpl::OnResize(const ViewMsg_Resize_Params& params) {
ShouldDisplayScrollbars(params.new_size.width(),
params.new_size.height()));
}
- UpdateScrollState(webview()->mainFrame());
+ has_scrolled_main_frame_ = true;
}
gfx::Size old_visible_viewport_size = visible_viewport_size_;
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698