Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 473913006: Move InfoMapTest to extensions_unittests (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move InfoMapTest to extensions_unittests extensions::InfoMap lives in src/extensions, so run its test suite as part of extensions_unittests. Two tests are left in Chrome's unit_tests because they depends on the "notifications" permission being available to hosted apps. BUG=397164 TEST=unit_tests ChromeInfoMapTest, extensions_unittests InfoMapTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291428

Patch Set 1 #

Patch Set 2 : (info-map) split out chrome part #

Patch Set 3 : (info-map) similarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -210 lines) Patch
A + chrome/browser/extensions/chrome_info_map_unittest.cc View 1 2 5 chunks +22 lines, -122 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/info_map_unittest.cc View 1 4 chunks +3 lines, -87 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
James Cook
yoz, PTAL. I'll send out my change to TestExtensionsClient (to add permissions features) separately, as ...
6 years, 4 months ago (2014-08-21 23:07:03 UTC) #1
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-22 00:34:30 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-22 01:32:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/473913006/40001
6 years, 4 months ago (2014-08-22 01:34:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 03:27:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 03:30:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8367)
6 years, 4 months ago (2014-08-22 03:30:02 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-22 15:36:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/473913006/40001
6 years, 4 months ago (2014-08-22 15:38:19 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 16:34:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291428

Powered by Google App Engine
This is Rietveld 408576698