Fix in compiler pass: cr.defineProperty() with 2 arguments means opt_kind == cr.PropertyKind.JS

third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.google.javascript.jscomp;
 
 import com.google.javascript.jscomp.NodeTraversal.AbstractPostOrderCallback;
 import com.google.javascript.rhino.IR;
 import com.google.javascript.rhino.JSDocInfoBuilder;
 import com.google.javascript.rhino.JSTypeExpression;
@@ skipping 102 matching lines @@
         } else {
             setJsDocWithType(getPropNode, new Node(Token.QMARK));
         }
 
         Node definitionNode = IR.exprResult(getPropNode).srcref(parent);
 
         parent.getParent().addChildAfter(definitionNode, parent);
     }
 
     private Node getTypeByCrPropertyKind(Node propertyKind) {
+        if (propertyKind == null || propertyKind.matchesQualifiedName("cr.PropertyKind.JS")) {
+            return new Node(Token.QMARK);
+        }
         if (propertyKind.matchesQualifiedName("cr.PropertyKind.ATTR")) {
             return IR.string("string");
         }
         if (propertyKind.matchesQualifiedName("cr.PropertyKind.BOOL_ATTR")) {
             return IR.string("boolean");
         }
-        if (propertyKind.matchesQualifiedName("cr.PropertyKind.JS")) {
-            return new Node(Token.QMARK);
-        }
         compiler.report(JSError.make(propertyKind, CR_DEFINE_PROPERTY_INVALID_PROPERTY_KIND,
                 propertyKind.getQualifiedName()));
         return null;
     }
 
     private void setJsDocWithType(Node target, Node type) {
         JSDocInfoBuilder builder = new JSDocInfoBuilder(false);
         builder.recordType(new JSTypeExpression(type, ""));
         target.setJSDocInfo(builder.build(target));
     }
@@ skipping 190 matching lines @@
         }
 
         private Node buildQualifiedName(Node internalName) {
             String externalName = this.exports.get(internalName.getString());
             return NodeUtil.newQualifiedNameNode(compiler.getCodingConvention(),
                     this.namespaceName + "." + externalName).srcrefTree(internalName);
         }
     }
 
 }