Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473803003: Fix PromiseHasRejectHandler. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
aandrey
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix PromiseHasRejectHandler. The odd-numbered items in the queue are deferred objects, not promises. R=aandrey@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23143

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : updated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M src/promise.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-by-default-reject-handler.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-by-default-reject-handler.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/debug-promises/throw-eventually-caught.js View 1 2 1 chunk +17 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 4 months ago (2014-08-14 12:00:11 UTC) #1
aandrey
lgtm https://codereview.chromium.org/473803003/diff/20001/test/mjsunit/es6/debug-promises/throw-eventually-caught.js File test/mjsunit/es6/debug-promises/throw-eventually-caught.js (right): https://codereview.chromium.org/473803003/diff/20001/test/mjsunit/es6/debug-promises/throw-eventually-caught.js#newcode9 test/mjsunit/es6/debug-promises/throw-eventually-caught.js:9: // We expect an Exception debug event with ...
6 years, 4 months ago (2014-08-17 17:47:29 UTC) #2
Yang
On 2014/08/17 17:47:29, aandrey wrote: > lgtm > > https://codereview.chromium.org/473803003/diff/20001/test/mjsunit/es6/debug-promises/throw-eventually-caught.js > File test/mjsunit/es6/debug-promises/throw-eventually-caught.js (right): > ...
6 years, 4 months ago (2014-08-18 08:42:15 UTC) #3
Yang
6 years, 4 months ago (2014-08-18 08:43:19 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as 23143 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698