mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl - Issue 473793004: Mojo C++ bindings: better log message for serialization warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

Issue 473793004: Mojo C++ bindings: better log message for serialization warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('K') | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

index f81bbb44e8c51d260824eb19804939e3c31790e2..849bf255d646b44feb0103c4cadae05cdb748aff 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

@@ -25,7 +25,8 @@ void Serialize_({{struct.name}}Ptr input, mojo::internal::Buffer* buf,

MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(

mojo::internal::IsNonNullableValidationEnabled() &&

!result->{{pf.field.name}}.ptr,

- mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER);

+ mojo::internal::VALIDATION_ERROR_UNEXPECTED_NULL_POINTER,

+ "null {{pf.field.name}} field");

hansmuller 2014/08/21 00:26:40 It might be useful include the name of the struct

yzshen1 2014/08/21 05:57:49 Done.

{%- endif %}

{%- elif pf.field.kind|is_any_handle_kind %}

{%- if pf.field.kind|is_interface_kind %}

@@ -37,7 +38,8 @@ void Serialize_({{struct.name}}Ptr input, mojo::internal::Buffer* buf,

MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(

mojo::internal::IsNonNullableValidationEnabled() &&

!result->{{pf.field.name}}.is_valid(),

- mojo::internal::VALIDATION_ERROR_UNEXPECTED_INVALID_HANDLE);

+ mojo::internal::VALIDATION_ERROR_UNEXPECTED_INVALID_HANDLE,

+ "invalid {{pf.field.name}} field");

{%- endif %}

{%- else %}

result->{{pf.field.name}} = input->{{pf.field.name}};