Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Unified Diff: mojo/public/cpp/bindings/lib/validation_errors.h

Issue 473793004: Mojo C++ bindings: better log message for serialization warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/validation_errors.h
diff --git a/mojo/public/cpp/bindings/lib/validation_errors.h b/mojo/public/cpp/bindings/lib/validation_errors.h
index 3de04e32c09c75d007dc7003049fcb5c148b8473..d9d8ff8d445b4fc4f1782846e8f1f453a59ec904 100644
--- a/mojo/public/cpp/bindings/lib/validation_errors.h
+++ b/mojo/public/cpp/bindings/lib/validation_errors.h
@@ -106,9 +106,10 @@ bool IsNonNullableValidationEnabled();
// of the serialzation result.
//
// In non-debug build, does nothing (not even compiling |condition|).
-#define MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(condition, error) \
+#define MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(condition, error, cause) \
MOJO_DLOG_IF(FATAL, (condition) && !ReportSerializationWarning(error)) \
<< "The outgoing message will trigger " \
- << ValidationErrorToString(error) << " at the receiving side.";
+ << ValidationErrorToString(error) << " at the receiving side. (" \
hansmuller 2014/08/21 00:26:40 I'm sure this is fine as is, but maybe you should
yzshen1 2014/08/21 05:57:49 Done.
+ << cause << ")";
#endif // MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_

Powered by Google App Engine
This is Rietveld 408576698