Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473793003: Video Player: Adds hover state cast icons (Closed)

Created:
6 years, 4 months ago by yoshiki
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Video Player: Adds hover state cast icons BUG=402953 TEST=Move the cursor on cast icon and see the hover icon on the white background. R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290202

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ui/file_manager/video_player/css/header.css View 1 1 chunk +12 lines, -0 lines 0 comments Download
A ui/file_manager/video_player/images/100/cast_off_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/100/cast_on_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/200/cast_off_hover.png View Binary file 0 comments Download
A ui/file_manager/video_player/images/200/cast_on_hover.png View Binary file 0 comments Download

Messages

Total messages: 18 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 4 months ago (2014-08-14 08:20:09 UTC) #1
hirono
On 2014/08/14 08:20:09, yoshiki wrote: > @hirono, PTAL. Thanks. lgtm!
6 years, 4 months ago (2014-08-14 09:24:30 UTC) #2
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-14 10:17:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/473793003/1
6 years, 4 months ago (2014-08-14 10:20:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 15:10:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 17:44:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/6025)
6 years, 4 months ago (2014-08-14 17:44:45 UTC) #7
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-15 08:15:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/473793003/1
6 years, 4 months ago (2014-08-15 08:16:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 08:22:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 08:27:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/6376)
6 years, 4 months ago (2014-08-15 08:27:42 UTC) #12
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-18 01:35:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/473793003/1
6 years, 4 months ago (2014-08-18 01:36:35 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 01:40:19 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 01:42:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/6878)
6 years, 4 months ago (2014-08-18 01:42:47 UTC) #17
yoshiki
6 years, 4 months ago (2014-08-18 02:37:28 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 manually as 290202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698