Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 473763004: Refactor QuicConnection's async write behavior to record a packet as (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_release
Project:
chromium
Visibility:
Public.

Description

Refactor QuicConnection's async write behavior to record a packet as sent as soon as the write starts, not when it completes. In QuicStreamFactoryTest, MockClock's now() is returning 0 and that was causing a DFATAL in QuicUnackedPacketMap::GetLastPacketSentTime(). Noticed, in QuicConnection unittests, we are advancing clock by 1 second and made a similar change to QuicStreamFactoryTest's MockClock. Merge internal change: 73648585 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -81 lines) Patch
M net/quic/quic_connection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_connection.cc View 4 chunks +36 lines, -54 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-08-21 22:54:09 UTC) #1
Ryan Hamilton
6 years, 4 months ago (2014-08-21 23:02:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698