Update data reduction proxy statistics prefs less often on desktop

chrome/browser/net/chrome_network_delegate.h

Index: chrome/browser/net/chrome_network_delegate.h
diff --git a/chrome/browser/net/chrome_network_delegate.h b/chrome/browser/net/chrome_network_delegate.h
index 0431a660c7a652c4ad599b54b134874307080107..143df4b15e19801e78aca0fffc35df6b6a826f29 100644
--- a/chrome/browser/net/chrome_network_delegate.h
+++ b/chrome/browser/net/chrome_network_delegate.h
@@ -38,8 +38,9 @@ class Predictor;
 namespace data_reduction_proxy {
 class DataReductionProxyAuthRequestHandler;
 class DataReductionProxyParams;
+class DataReductionProxyStatisticsPrefs;
 class DataReductionProxyUsageStats;
-}
+}  // namespace data_reduction_proxy

[mmenke, 2014/09/05 15:23:09]

nit:  Comment not needed (End namespace comments generally aren't used for
forward declarations).

Please remove the domain_reliability one while you're at it.

[megjablon, 2014/09/05 20:56:38]

Good to know! Thanks

 
 namespace domain_reliability {
 class DomainReliabilityMonitor;
@@ -166,6 +167,12 @@ class ChromeNetworkDelegate : public net::NetworkDelegate {
     data_reduction_proxy_auth_request_handler_ = handler;
   }
 
+  // |statistics_prefs_| must outlive this ChromeNetworkDelegate.
+  void set_data_reduction_proxy_statistics_prefs(
+      data_reduction_proxy::DataReductionProxyStatisticsPrefs* service) {
+    statistics_prefs_ = service;

[bengr, 2014/09/04 21:18:21]

Rename "service" as "statistics_prefs"

[megjablon, 2014/09/05 20:56:39]

Done.

+  }
+
   void set_on_resolve_proxy_handler(OnResolveProxyHandler handler) {
     on_resolve_proxy_handler_ = handler;
   }
@@ -319,6 +326,7 @@ class ChromeNetworkDelegate : public net::NetworkDelegate {
       data_reduction_proxy_usage_stats_;
   data_reduction_proxy::DataReductionProxyAuthRequestHandler*
   data_reduction_proxy_auth_request_handler_;

[mmenke, 2014/09/05 15:23:09]

While you're here, this should be indented 4 more.

[megjablon, 2014/09/05 20:56:38]

Done.

+  data_reduction_proxy::DataReductionProxyStatisticsPrefs* statistics_prefs_;

[mmenke, 2014/09/05 15:23:09]

optional:  Actually, I think we don't need to know how it works.  Maybe just
call it DataReductionProxyStatistics?

[mmenke, 2014/09/05 15:23:09]

data_reduction_proxy_statistics_prefs_ is more consistent with the other names.

[megjablon, 2014/09/05 20:56:38]

Agreed.

[megjablon, 2014/09/05 20:56:39]

I think it makes more sense to keep Prefs on it because it operates as a pref
service for these data reduction proxy prefs.

 
   OnResolveProxyHandler on_resolve_proxy_handler_;
   ProxyConfigGetter proxy_config_getter_;