Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_delayed_pref_service_unittest.cc

Issue 473723002: Update data reduction proxy statistics prefs less often on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tooManyWritesPatch
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_delayed_pref_service_unittest.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_delayed_pref_service_unittest.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_delayed_pref_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d027e0e56e2933e862a9051c43125cdbaca0d01c
--- /dev/null
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_delayed_pref_service_unittest.cc
@@ -0,0 +1,131 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_registry_simple.h"
+#include "base/prefs/testing_pref_service.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/time/time.h"
+#include "components/data_reduction_proxy/browser/data_reduction_proxy_delayed_pref_service.h"
+#include "components/data_reduction_proxy/common/data_reduction_proxy_pref_names.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+const size_t kNumDaysInHistory = 60;
+
+int64 GetListPrefInt64Value(
+ const base::ListValue& list_update, size_t index) {
+ std::string string_value;
+ EXPECT_TRUE(list_update.GetString(index, &string_value));
+
+ int64 value = 0;
+ EXPECT_TRUE(base::StringToInt64(string_value, &value));
+ return value;
+}
+
+} // namespace
+
+namespace data_reduction_proxy {
+class DataReductionProxyDelayedPrefServiceTest : public testing::Test {
+ protected:
+ DataReductionProxyDelayedPrefServiceTest()
+ : task_runner_(scoped_refptr<base::TestSimpleTaskRunner>(
+ new base::TestSimpleTaskRunner())),
+ pref_service_(new DataReductionProxyDelayedPrefService(
+ &simple_pref_service_,
+ task_runner_,
+ base::TimeDelta::FromMinutes(60))) {}
+
+ virtual void SetUp() OVERRIDE {
+ PrefRegistrySimple* registry = simple_pref_service_.registry();
+ registry->RegisterInt64Pref(
+ data_reduction_proxy::prefs::kHttpReceivedContentLength, 0);
+ registry->RegisterInt64Pref(
+ data_reduction_proxy::prefs::kHttpOriginalContentLength, 32);
+
+ registry->RegisterListPref(data_reduction_proxy::prefs::
+ kDailyHttpOriginalContentLength);
+ registry->RegisterListPref(data_reduction_proxy::prefs::
+ kDailyHttpReceivedContentLength);
+
+ CreatePrefList(
+ data_reduction_proxy::prefs::kDailyHttpOriginalContentLength);
+ CreatePrefList(
+ data_reduction_proxy::prefs::kDailyHttpReceivedContentLength);
+ }
+
+ // Create daily pref list of |kNumDaysInHistory| zero values.
+ void CreatePrefList(const char* pref) {
+ base::ListValue* update = pref_service_->GetList(pref);
+ update->Clear();
+ for (size_t i = 0; i < kNumDaysInHistory; ++i) {
+ update->Insert(0, new base::StringValue(base::Int64ToString(0)));
+ }
+ }
+
+ // Verify the pref list values in |pref_service_| are equal to those in
+ // |simple_pref_service| for |pref|.
+ void VerifyPrefListWasWritten(const char* pref) {
+ const base::ListValue* delayed_list = pref_service_->GetList(pref);
+ const base::ListValue* written_list = simple_pref_service_.GetList(pref);
+ ASSERT_EQ(delayed_list->GetSize(), written_list->GetSize());
+ size_t count = delayed_list->GetSize();
+
+ for (size_t i = 0; i < count; ++i) {
+ EXPECT_EQ(
+ GetListPrefInt64Value(*delayed_list, i),
+ GetListPrefInt64Value(*written_list, i));
+ }
+ }
+
+ // Verify the pref value in |pref_service_| are equal to that in
+ // |simple_pref_service|.
+ void VerifyPrefWasWritten(const char* pref) {
+ int64 delayed_pref = pref_service_->GetInt64(pref);
+ int64 written_pref = simple_pref_service_.GetInt64(pref);
+ EXPECT_EQ(delayed_pref, written_pref);
+ }
+
+ scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+ TestingPrefServiceSimple simple_pref_service_;
+ DataReductionProxyDelayedPrefService* pref_service_;
+};
+
+TEST_F(DataReductionProxyDelayedPrefServiceTest, WritePrefs) {
+ const int64 kOriginalLength = 150;
+ const int64 kReceivedLength = 100;
+
+ pref_service_->SetInt64(
+ data_reduction_proxy::prefs::kHttpOriginalContentLength, kOriginalLength);
+ pref_service_->SetInt64(
+ data_reduction_proxy::prefs::kHttpReceivedContentLength, kReceivedLength);
+
+ base::ListValue* original_daily_content_length_list = pref_service_->GetList(
+ data_reduction_proxy::prefs::kDailyHttpOriginalContentLength);
+ base::ListValue* received_daily_content_length_list = pref_service_->GetList(
+ data_reduction_proxy::prefs::kDailyHttpReceivedContentLength);
+
+ for (size_t i = 0; i < kNumDaysInHistory; ++i) {
+ original_daily_content_length_list->Set(
+ i, new base::StringValue(base::Int64ToString(i)));
+ }
+
+ received_daily_content_length_list->Clear();
+ for (size_t i = 0; i < kNumDaysInHistory/2; ++i) {
+ received_daily_content_length_list->Set(
+ i, new base::StringValue(base::Int64ToString(i)));
+ }
+
+ task_runner_->RunPendingTasks();
+
+ VerifyPrefWasWritten(data_reduction_proxy::prefs::kHttpOriginalContentLength);
+ VerifyPrefWasWritten(data_reduction_proxy::prefs::kHttpReceivedContentLength);
+ VerifyPrefListWasWritten(
+ data_reduction_proxy::prefs::kDailyHttpOriginalContentLength);
+ VerifyPrefListWasWritten(
+ data_reduction_proxy::prefs::kDailyHttpReceivedContentLength);
+}
+
+} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698