components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc - Issue 473723002: Update data reduction proxy statistics prefs less often on desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc

Issue 473723002: Update data reduction proxy statistics prefs less often on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tooManyWritesPatch

Patch Set: Addressed bengr comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.h » ('j') | components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc

index 9e77071709a43c8f135a36e33ec4bac241f4bf5c..c47d328a77f8e357373a9c981132c174caf294e9 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_settings_unittest.cc

@@ -422,7 +422,6 @@ TEST_F(DataReductionProxySettingsTest, CheckInitMetricsWhenNotAllowed) {

new net::TestURLRequestContextGetter(base::MessageLoopProxy::current());

settings_->InitDataReductionProxySettings(

&pref_service_,

- &pref_service_,

request_context.get());

settings_->SetOnDataReductionEnabledCallback(

base::Bind(&DataReductionProxySettingsTestBase::