Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h

Issue 473723002: Update data reduction proxy statistics prefs less often on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tooManyWritesPatch
Patch Set: Addressed bengr comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h b/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h
index b308742aa3426fa6ece7a7f5a93dbb9322c2f86b..b98758262aa83e72cbb957550ca8e55e33ca9d80 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h
@@ -6,13 +6,12 @@
#define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_METRICS_H_
#include "base/time/time.h"
+#include "components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.h"
bengr 2014/08/28 21:38:34 I think you should just be able to forward declare
megjablon 2014/08/30 01:10:04 Done.
namespace net {
class URLRequest;
}
-class PrefService;
-
namespace data_reduction_proxy {
enum DataReductionProxyRequestType {
@@ -46,7 +45,8 @@ void UpdateContentLengthPrefsForDataReductionProxy(
int original_content_length,
bool with_data_reduction_proxy_enabled,
DataReductionProxyRequestType request_type,
- base::Time now, PrefService* prefs);
+ base::Time now,
+ DataReductionProxyStatisticsPrefs* prefs);
// Records daily data savings statistics to prefs and reports data savings UMA.
void UpdateContentLengthPrefs(
@@ -54,7 +54,7 @@ void UpdateContentLengthPrefs(
int original_content_length,
bool with_data_reduction_proxy_enabled,
DataReductionProxyRequestType request_type,
- PrefService* prefs);
+ DataReductionProxyStatisticsPrefs* prefs);
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698