Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.cc

Issue 473723002: Update data reduction proxy statistics prefs less often on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tooManyWritesPatch
Patch Set: Fixing nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/data_reduction_proxy/browser/data_reduction_proxy_statistic s_prefs.h"
6
7 #include "base/bind.h"
8 #include "base/location.h"
9 #include "base/logging.h"
10 #include "base/prefs/pref_service.h"
11 #include "base/prefs/scoped_user_pref_update.h"
12 #include "base/sequenced_task_runner.h"
13 #include "base/strings/string_number_conversions.h"
14 #include "base/time/time.h"
15 #include "base/values.h"
16
17 namespace data_reduction_proxy {
18
19 DataReductionProxyStatisticsPrefs::DataReductionProxyStatisticsPrefs(
20 PrefService* prefs,
21 scoped_refptr<base::SequencedTaskRunner> task_runner,
22 const base::TimeDelta& delay)
23 : pref_service_(prefs),
24 task_runner_(task_runner),
25 weak_factory_(this),
26 delay_(delay),
27 delayed_task_posted_(false) {
28 DCHECK(prefs);
29 DCHECK_GE(delay.InMilliseconds(), 0);
30 Init();
31 }
32
33 DataReductionProxyStatisticsPrefs::~DataReductionProxyStatisticsPrefs() {}
34
35 void DataReductionProxyStatisticsPrefs::Init() {
36 if (delay_ == base::TimeDelta())
37 return;
38
39 // Init all int64 prefs.
40 InitInt64Pref(data_reduction_proxy::prefs::
41 kDailyHttpContentLengthLastUpdateDate);
42 InitInt64Pref(data_reduction_proxy::prefs::kHttpReceivedContentLength);
43 InitInt64Pref(data_reduction_proxy::prefs::kHttpOriginalContentLength);
44
45 // Init all list prefs.
46 InitListPref(data_reduction_proxy::prefs::
47 kDailyContentLengthHttpsWithDataReductionProxyEnabled);
48 InitListPref(data_reduction_proxy::prefs::
49 kDailyContentLengthLongBypassWithDataReductionProxyEnabled);
50 InitListPref(data_reduction_proxy::prefs::
51 kDailyContentLengthShortBypassWithDataReductionProxyEnabled);
52 InitListPref(data_reduction_proxy::prefs::
53 kDailyContentLengthUnknownWithDataReductionProxyEnabled);
54 InitListPref(data_reduction_proxy::prefs::
55 kDailyContentLengthViaDataReductionProxy);
56 InitListPref(data_reduction_proxy::prefs::
57 kDailyContentLengthWithDataReductionProxyEnabled);
58 InitListPref(data_reduction_proxy::prefs::kDailyHttpOriginalContentLength);
59 InitListPref(data_reduction_proxy::prefs::kDailyHttpReceivedContentLength);
60 InitListPref(data_reduction_proxy::prefs::
61 kDailyOriginalContentLengthViaDataReductionProxy);
62 InitListPref(data_reduction_proxy::prefs::
63 kDailyOriginalContentLengthWithDataReductionProxyEnabled);
64 }
65
66 void DataReductionProxyStatisticsPrefs::InitInt64Pref(const char* pref) {
67 int64 pref_value = pref_service_->GetInt64(pref);
68 pref_map_[pref] = pref_value;
69 }
70
71 void DataReductionProxyStatisticsPrefs::InitListPref(const char* pref) {
72 scoped_ptr<base::ListValue> pref_value = scoped_ptr<base::ListValue>(
73 pref_service_->GetList(pref)->DeepCopy());
74 list_pref_map_.add(pref, pref_value.Pass());
75 }
76
77 int64 DataReductionProxyStatisticsPrefs::GetInt64(const char* pref_path) {
78 if (delay_ == base::TimeDelta())
79 return pref_service_->GetInt64(pref_path);
80
81 DataReductionProxyPrefMap::iterator iter = pref_map_.find(pref_path);
82 return iter->second;
83 }
84
85 void DataReductionProxyStatisticsPrefs::SetInt64(const char* pref_path,
86 int64 pref_value) {
87 if (delay_ == base::TimeDelta()) {
88 pref_service_->SetInt64(pref_path, pref_value);
89 return;
90 }
91
92 DelayedWritePrefs();
93 pref_map_[pref_path] = pref_value;
94 }
95
96 base::ListValue* DataReductionProxyStatisticsPrefs::GetList(
97 const char* pref_path) {
98 if (delay_ == base::TimeDelta())
99 return ListPrefUpdate(pref_service_, pref_path).Get();
100
101 DelayedWritePrefs();
102 return list_pref_map_.get(pref_path);
103 }
104
105 void DataReductionProxyStatisticsPrefs::WritePrefs() {
106 if (delay_ == base::TimeDelta())
107 return;
108 DCHECK(delayed_task_posted_);
109
110 for (DataReductionProxyPrefMap::iterator iter = pref_map_.begin();
111 iter != pref_map_.end(); ++iter) {
112 pref_service_->SetInt64(iter->first, iter->second);
113 }
114
115 for (DataReductionProxyListPrefMap::iterator iter = list_pref_map_.begin();
116 iter != list_pref_map_.end(); ++iter) {
117 TransferList(*(iter->second),
118 ListPrefUpdate(pref_service_, iter->first).Get());
119 }
120
121 delayed_task_posted_ = false;
122 }
123
124 void DataReductionProxyStatisticsPrefs::DelayedWritePrefs() {
125 // Only write after the first time posting the task.
126 if (delayed_task_posted_)
127 return;
128
129 task_runner_->PostDelayedTask(
130 FROM_HERE,
131 base::Bind(&DataReductionProxyStatisticsPrefs::WritePrefs,
132 weak_factory_.GetWeakPtr()),
133 delay_);
134
135 delayed_task_posted_ = true;
136 }
137
138 void DataReductionProxyStatisticsPrefs::TransferList(
139 const base::ListValue& from_list,
140 base::ListValue* to_list) {
141 to_list->Clear();
142 for (size_t i = 0; i < from_list.GetSize(); ++i) {
143 to_list->Set(i, new base::StringValue(base::Int64ToString(
144 GetListPrefInt64Value(from_list, i))));
145 }
146 }
147
148 int64 DataReductionProxyStatisticsPrefs::GetListPrefInt64Value(
149 const base::ListValue& list,
150 size_t index) {
151 std::string string_value;
152 if (!list.GetString(index, &string_value)) {
153 NOTREACHED();
154 return 0;
155 }
156
157 int64 value = 0;
158 bool rv = base::StringToInt64(string_value, &value);
159 DCHECK(rv);
160 return value;
161 }
162
163 } // namespace data_reduction_proxy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698