Update data reduction proxy statistics prefs less often on desktop

chrome/test/data/webui/net_internals/bandwidth_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['net_internals_test.js']);
 
 // Anonymous namespace
 (function() {
 
@@ skipping 24 matching lines @@
   /**
    * Switches to the bandwidth tab, loads a page in the background, and waits
    * for the arrival of network statistics.
    *
    * @param {string} url URL to be fetched.
    */
   start: function(url) {
     assertEquals('string', typeof url);
     this.url_ = url;
     g_browser.addSessionNetworkStatsObserver(this, true);
-    g_browser.addHistoricNetworkStatsObserver(this, true);
+    g_browser.addHistoricNetworkStatsObserver(this, false);

[mmenke, 2014/09/18 14:54:46]

Hrm...Really not sure why this is needed - we should send data to new observers
even if it hasn't changed...  Not going to block this CL on the issue, or
require you guys to investigate...but it's strange we need to do it.

     NetInternalsTest.switchToView('bandwidth');
     chrome.send('loadPage', [this.url_]);
   },
 
   /**
    * Returns the float value the specified cell of the bandwidth table.
    */
   getBandwidthTableCell_: function(row, col) {
     return parseFloat(NetInternalsTest.getTbodyText(
         BandwidthView.MAIN_BOX_ID, row, col));
@@ skipping 57 matching lines @@
     }
   },
 
   /**
    * HistoricNetworkStatsObserver function.  Sanity checks the received data
    * and constructed table.
 
    * @param {object} networkStats State of the network session.
    */
   onHistoricNetworkStatsChanged: function(networkStats) {
-    if (this.isDone())
+    if (this.isDone() || this.historicVerified)

[mmenke, 2014/09/18 14:54:46]

nit:  May as well "|| this.sessionVerified" to the onSessionNetworkStatsChanged
call as well - not sure if either is needed, but I think it's better to be
consistent.

       return;
-    // Wait until the received content length is at least the size of
-    // our test page and favicon.
-    var expectedLength = this.expectedLength_ + this.faviconLength_;
-    if (networkStats.historic_received_content_length >= expectedLength) {
+    console.log("checking network stats");

[mmenke, 2014/09/18 14:54:46]

nit:  Remove logging.

+    // The received content length should be zero since the historic
+    // information only updates every hour.
+    var expectedLength = 0;
+    // Wait until the table has changed, otherwise the columns will be NaN
+    if (!isNaN(this.getBandwidthTableCell_(0, 2))) {
       expectLE(expectedLength, networkStats.historic_original_content_length);
-      // Column 2 contains historic information, and it should be the same as
-      // the session information, because previously there was no history.
+      // Column 2 contains historic information.
       this.validateBandwidthTableColumn_(2, expectedLength, expectedLength);
       this.historicVerified = true;
       this.completeIfDone();
     }
   }
 };
 
 /**
  * Loads a page and checks bandwidth statistics.
  */
 TEST_F('NetInternalsTest', 'netInternalsSessionBandwidthSucceed', function() {
   var taskQueue = new NetInternalsTest.TaskQueue(true);
   taskQueue.addTask(
       new NetInternalsTest.GetTestServerURLTask('files/title1.html'));
   // Load a page with a content length of 66 bytes and a 45-byte favicon.
   taskQueue.addTask(new BandwidthTask(66, 45));
   taskQueue.run();
 });
 
 })();  // Anonymous namespace