Update data reduction proxy statistics prefs less often on desktop

chrome/test/data/webui/net_internals/bandwidth_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Include test fixture.
 GEN_INCLUDE(['net_internals_test.js']);
 
 // Anonymous namespace
 (function() {
 
 /**
  * The task fetches a page as a way of determining if network statistics
  * (such as the aggregate received content length) change accordingly.
  * The URL is received from the previous task.
  *
  * Checks that we see all relevant events and update the corresponding table.
  *
  * @param {int} expectedLength The length of the content being loaded.
  * @param {int} faviconLength The length a favicon that is received.
  * @extends {NetInternalsTest.Task}
  * @constructor
  */
 function BandwidthTask(expectedLength, faviconLength) {
   NetInternalsTest.Task.call(this);
   this.url_ = null;
   this.expectedLength_ = expectedLength;
   this.faviconLength_ = faviconLength;
-  this.sessionVerified = false;
-  this.historicVerified = false;
+  this.verified = false;
 }
 
 BandwidthTask.prototype = {
   __proto__: NetInternalsTest.Task.prototype,
 
   /**
    * Switches to the bandwidth tab, loads a page in the background, and waits
    * for the arrival of network statistics.
    *
    * @param {string} url URL to be fetched.
    */
   start: function(url) {
     assertEquals('string', typeof url);
     this.url_ = url;
     g_browser.addSessionNetworkStatsObserver(this, true);
-    g_browser.addHistoricNetworkStatsObserver(this, true);
     NetInternalsTest.switchToView('bandwidth');
     chrome.send('loadPage', [this.url_]);
   },
 
   /**
    * Returns the float value the specified cell of the bandwidth table.
    */
   getBandwidthTableCell_: function(row, col) {
     return parseFloat(NetInternalsTest.getTbodyText(
         BandwidthView.MAIN_BOX_ID, row, col));
@@ skipping 22 matching lines @@
     expectLE(expectedReceivedKB, row2);
     expectFalse(isNaN(row3));
     expectFalse(isNaN(row4));
   },
 
   /**
    * A task is complete only when session and historic counters have been
    * verified to reflect the expected number of bytes received.
    */
   completeIfDone: function() {
-    if (this.historicVerified && this.sessionVerified) {
+    if (this.verified) {
       // Check number of rows in the table.
       NetInternalsTest.checkTbodyRows(BandwidthView.MAIN_BOX_ID, 4);
       this.onTaskDone();
     }
   },
 
   /**
-   * SessionNetworkStatsObserver function.  Sanity checks the received data
-   * and constructed table.
+   * SessionNetworkStatsObserver function.  The historic stats and session
+   * stats columns should be updated by the session stats change.  Sanity
+   * checks the received data and constructed table.
 
    * @param {object} networkStats State of the network session.
    */
   onSessionNetworkStatsChanged: function(networkStats) {
     if (this.isDone())
       return;
     // Wait until the received content length is at least the size of
     // our test page and favicon.
     var expectedLength = this.expectedLength_ + this.faviconLength_;
     if (networkStats.session_received_content_length >= expectedLength) {
       expectLE(expectedLength, networkStats.session_original_content_length);
       // Column 1 contains session information.
       this.validateBandwidthTableColumn_(1, expectedLength, expectedLength);
-      this.sessionVerified = true;
-      this.completeIfDone();
-    }
-  },
-
-  /**
-   * HistoricNetworkStatsObserver function.  Sanity checks the received data
-   * and constructed table.
-
-   * @param {object} networkStats State of the network session.
-   */
-  onHistoricNetworkStatsChanged: function(networkStats) {
-    if (this.isDone())
-      return;
-    // Wait until the received content length is at least the size of
-    // our test page and favicon.
-    var expectedLength = this.expectedLength_ + this.faviconLength_;
-    if (networkStats.historic_received_content_length >= expectedLength) {
-      expectLE(expectedLength, networkStats.historic_original_content_length);
-      // Column 2 contains historic information, and it should be the same as
-      // the session information, because previously there was no history.
+      // Also check column 2, the historic information.
       this.validateBandwidthTableColumn_(2, expectedLength, expectedLength);
-      this.historicVerified = true;
+      this.verified = true;
       this.completeIfDone();

[mmenke, 2014/09/15 15:11:02]

Shouldn't onHistoricNetworkStatsChanged still be called (Possibly with 0)?

[megjablon, 2014/09/15 18:19:23]

The test times out since it waits on the historic network stats to change which
only happens every hour. Any alternative suggestions on how to fix this?

[mmenke, 2014/09/16 14:18:45]

Why can we rely on onSessionNetworkStatsChanged being called, but not
onHistoricNetworkStatsChanged?  They're both only called every hour, right?

We could have net-internals pull the stats directly from the data reduction
proxy settings, but that seems like a bit of a pain...  That having been said,
if the stats only update once an hour, is there even any utility to exposing
them via net-internals?  May be simplest just to remove the tab (Note:  If you
guys still find it at all useful, I'm completely fine with keeping it.  Not
trying to get something useful removed, just uncertain if it is still useful).

     }
   }
 };
 
 /**
  * Loads a page and checks bandwidth statistics.
  */
 TEST_F('NetInternalsTest', 'netInternalsSessionBandwidthSucceed', function() {
   var taskQueue = new NetInternalsTest.TaskQueue(true);
   taskQueue.addTask(
       new NetInternalsTest.GetTestServerURLTask('files/title1.html'));
   // Load a page with a content length of 66 bytes and a 45-byte favicon.
   taskQueue.addTask(new BandwidthTask(66, 45));
   taskQueue.run();
 });
 
 })();  // Anonymous namespace