Update data reduction proxy statistics prefs less often on desktop

android_webview/browser/aw_browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_browser_context.h"
 
 #include "android_webview/browser/aw_form_database_service.h"
 #include "android_webview/browser/aw_pref_store.h"
 #include "android_webview/browser/aw_quota_manager_bridge.h"
 #include "android_webview/browser/aw_resource_context.h"
@@ skipping 86 matching lines @@
   proxy_settings->SetDataReductionProxyEnabled(data_reduction_proxy_enabled_);
 }
 
 void AwBrowserContext::PreMainMessageLoopRun() {
   cookie_store_ = CreateCookieStore(this);
 #if defined(SPDY_PROXY_AUTH_ORIGIN)
   data_reduction_proxy_settings_.reset(
       new DataReductionProxySettings(
           new data_reduction_proxy::DataReductionProxyParams(
               data_reduction_proxy::DataReductionProxyParams::kAllowed)));
+  // Unlike in Chrome, DataReductionProxyStatistisPrefs is not instantiated

[bengr, 2014/09/04 21:18:21]

I would change this comment to:

// Compression statistics are not gathered for WebView, so
// DataReductionProxyStatisticsPrefs is not instantiated
// and passed to the network delegate. 

and I would move the comment to wherever we call other setters on the
NetworkDelegate.

[megjablon, 2014/09/05 20:56:38]

Done.

+  // for Android WebView and no local DataReductionProxyPrefs are recorded.
 #endif
   scoped_ptr<DataReductionProxyConfigService>
       data_reduction_proxy_config_service(
           new DataReductionProxyConfigService(
               scoped_ptr<net::ProxyConfigService>(
                   net::ProxyService::CreateSystemProxyConfigService(
                       BrowserThread::GetMessageLoopProxyForThread(
                           BrowserThread::IO),
                           NULL /* Ignored on Android */)).Pass()));
   if (data_reduction_proxy_settings_.get()) {
@@ skipping 85 matching lines @@
   base::PrefServiceFactory pref_service_factory;
   pref_service_factory.set_user_prefs(make_scoped_refptr(new AwPrefStore()));
   pref_service_factory.set_read_error_callback(base::Bind(&HandleReadError));
   user_pref_service_ = pref_service_factory.Create(pref_registry).Pass();
 
   user_prefs::UserPrefs::Set(this, user_pref_service_.get());
 
   if (data_reduction_proxy_settings_.get()) {
     data_reduction_proxy_settings_->InitDataReductionProxySettings(
         user_pref_service_.get(),
-        user_pref_service_.get(),
         GetRequestContext());
 
     data_reduction_proxy_settings_->SetDataReductionProxyEnabled(
         data_reduction_proxy_enabled_);
   }
 }
 
 base::FilePath AwBrowserContext::GetPath() const {
   return context_storage_path_;
 }
@@ skipping 64 matching lines @@
 
 void AwBrowserContext::RebuildTable(
     const scoped_refptr<URLEnumerator>& enumerator) {
   // Android WebView rebuilds from WebChromeClient.getVisitedHistory. The client
   // can change in the lifetime of this WebView and may not yet be set here.
   // Therefore this initialization path is not used.
   enumerator->OnComplete(true);
 }
 
 }  // namespace android_webview