Update data reduction proxy statistics prefs less often on desktop

android_webview/browser/aw_browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_browser_context.h"
 
 #include "android_webview/browser/aw_form_database_service.h"
 #include "android_webview/browser/aw_pref_store.h"
 #include "android_webview/browser/aw_quota_manager_bridge.h"
 #include "android_webview/browser/aw_resource_context.h"
 #include "android_webview/browser/jni_dependency_factory.h"
 #include "android_webview/browser/net/aw_url_request_context_getter.h"
 #include "android_webview/browser/net/init_native_callback.h"
 #include "base/bind.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/pref_service_factory.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_prefs.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings.h"
+#include "components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.h"
 #include "components/user_prefs/user_prefs.h"
 #include "components/visitedlink/browser/visitedlink_master.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/ssl_host_state_delegate.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "net/cookies/cookie_store.h"
 #include "net/proxy/proxy_service.h"
 
 using base::FilePath;
 using content::BrowserThread;
 using data_reduction_proxy::DataReductionProxyConfigService;
 using data_reduction_proxy::DataReductionProxySettings;
+using data_reduction_proxy::DataReductionProxyStatisticsPrefs;
 
 namespace android_webview {
 
 namespace {
 
 // Shows notifications which correspond to PersistentPrefStore's reading errors.
 void HandleReadError(PersistentPrefStore::PrefReadError error) {
 }
 
 AwBrowserContext* g_browser_context = NULL;
@@ skipping 51 matching lines @@
   proxy_settings->SetDataReductionProxyEnabled(data_reduction_proxy_enabled_);
 }
 
 void AwBrowserContext::PreMainMessageLoopRun() {
   cookie_store_ = CreateCookieStore(this);
 #if defined(SPDY_PROXY_AUTH_ORIGIN)
   data_reduction_proxy_settings_.reset(
       new DataReductionProxySettings(
           new data_reduction_proxy::DataReductionProxyParams(
               data_reduction_proxy::DataReductionProxyParams::kAllowed)));
+  data_reduction_proxy_statistics_prefs_.reset(
+      new DataReductionProxyStatisticsPrefs(
+          user_pref_service_.get(),

[sgurun-gerrit only, 2014/09/04 00:32:26]

unfortunately this will not work, because we create user_pref_service_ later
when AwContents is created. It will be a null here. You could call
AwBrowserContext::CreateUserPrefServiceIfNecessary() here but then I think it is
better to cleanup the code here a little bit so that this method is not called
from AwContents anymore. 
will be OOO for a while so making benm@ as the reviewer for this CL.

[megjablon, 2014/09/04 18:28:51]

Instead we are just not going to instantiate  DataReductionProxyStatisticsPrefs
and have support for a null statistics_prefs_ in DataReductionProxySettings
since webview does not use these prefs anyway.

+          base::MessageLoopProxy::current(),
+          base::TimeDelta()));
 #endif
   scoped_ptr<DataReductionProxyConfigService>
       data_reduction_proxy_config_service(
           new DataReductionProxyConfigService(
               scoped_ptr<net::ProxyConfigService>(
                   net::ProxyService::CreateSystemProxyConfigService(
                       BrowserThread::GetMessageLoopProxyForThread(
                           BrowserThread::IO),
                           NULL /* Ignored on Android */)).Pass()));
   if (data_reduction_proxy_settings_.get()) {
@@ skipping 85 matching lines @@
   base::PrefServiceFactory pref_service_factory;
   pref_service_factory.set_user_prefs(make_scoped_refptr(new AwPrefStore()));
   pref_service_factory.set_read_error_callback(base::Bind(&HandleReadError));
   user_pref_service_ = pref_service_factory.Create(pref_registry).Pass();
 
   user_prefs::UserPrefs::Set(this, user_pref_service_.get());
 
   if (data_reduction_proxy_settings_.get()) {
     data_reduction_proxy_settings_->InitDataReductionProxySettings(
         user_pref_service_.get(),
-        user_pref_service_.get(),
         GetRequestContext());
 
+    data_reduction_proxy_settings_->SetDataReductionProxyStatisticsPrefs(
+        data_reduction_proxy_statistics_prefs_.get());
+
     data_reduction_proxy_settings_->SetDataReductionProxyEnabled(
         data_reduction_proxy_enabled_);
   }
 }
 
 base::FilePath AwBrowserContext::GetPath() const {
   return context_storage_path_;
 }
 
 bool AwBrowserContext::IsOffTheRecord() const {
@@ skipping 62 matching lines @@
 
 void AwBrowserContext::RebuildTable(
     const scoped_refptr<URLEnumerator>& enumerator) {
   // Android WebView rebuilds from WebChromeClient.getVisitedHistory. The client
   // can change in the lifetime of this WebView and may not yet be set here.
   // Therefore this initialization path is not used.
   enumerator->OnComplete(true);
 }
 
 }  // namespace android_webview