Issue 473703002: [Telemetry] Remove waits in telemetry_perf_unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 473703002: [Telemetry] Remove waits in telemetry_perf_unittests. (Closed)

Created:
6 years, 4 months ago by tonyg

Modified:
6 years, 4 months ago

Reviewers:
dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Remove waits in telemetry_perf_unittests. This reduces cycle time by about 15 seconds and has the desirable property that it prevents developers from doing anything racy with a Wait. Waits should only be used for a period of perf measurement like smoothness, energy, etc. They shouldn't be used to wait for some condition to be true. BUG=388256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289570

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -6 lines)			Patch
M	tools/perf/benchmarks/benchmark_unittest.py	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	tools/perf/measurements/smoothness_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/actions/action_runner.py	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_test.py	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/473703002/1

6 years, 4 months ago (2014-08-14 02:13:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 289570

Expand Messages | Collapse Messages