Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 473693003: Fix verifier_test_dll_1.dll warning (Closed)

Created:
6 years, 4 months ago by pmonette
Modified:
6 years, 4 months ago
Reviewers:
robertshield, mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

A warning was produced when compiling verifier_test_dll_1.dll. verifier_test_dll_1.dll.exp : warning LNK4070: /OUT:verifier_test_dll.dll directive in .EXP differs from output filename 'verifier_test_dll_1.dll'; ignoring directive BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/safe_browsing/verifier_test/verifier_test_dll_1.def View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pmonette_google.com
Fix warning. PTAL
6 years, 4 months ago (2014-08-15 17:34:57 UTC) #1
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-08-15 17:36:04 UTC) #2
robertshield
lgtm
6 years, 4 months ago (2014-08-15 17:36:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmonette@google.com/473693003/1
6 years, 4 months ago (2014-08-15 17:37:26 UTC) #4
pmonette_google.com
Hey Matt, can you check this CL please. I need owners' lgtm.
6 years, 4 months ago (2014-08-15 18:03:05 UTC) #5
mattm
lgtm
6 years, 4 months ago (2014-08-15 19:04:26 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 19:11:34 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 19:16:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 289970

Powered by Google App Engine
This is Rietveld 408576698