Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473683005: Get print preview intitiator before ClearInitiatorDetails(). (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@patches
Project:
chromium
Visibility:
Public.

Description

Get print preview intitiator before ClearInitiatorDetails(). BUG=407080 Committed: https://crrev.com/6d6f102f2da16454755ce6bf8cb765bedf0813a4 Cr-Commit-Position: refs/heads/master@{#291836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 3 months ago (2014-08-25 23:40:07 UTC) #1
Noam Samuel
noamsml@chromium.org changed reviewers: + noamsml@chromium.org
6 years, 3 months ago (2014-08-25 23:40:08 UTC) #2
Noam Samuel
lgtm
6 years, 3 months ago (2014-08-25 23:40:08 UTC) #3
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-25 23:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/473683005/1
6 years, 3 months ago (2014-08-25 23:40:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 02:31:20 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 02:31:21 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 04:02:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/473683005/1
6 years, 3 months ago (2014-08-26 04:03:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 42cee90af708a18732a2ab098e8c02aae5599f83
6 years, 3 months ago (2014-08-26 04:21:09 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:40:20 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6d6f102f2da16454755ce6bf8cb765bedf0813a4
Cr-Commit-Position: refs/heads/master@{#291836}

Powered by Google App Engine
This is Rietveld 408576698