Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: build/android/buildbot/bb_device_status_check.py

Issue 473683003: Do not use device if it had to be turned off because of critical battery level. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_status_check.py
diff --git a/build/android/buildbot/bb_device_status_check.py b/build/android/buildbot/bb_device_status_check.py
index 41bf1721e33eb8309f955d7ced8d06f9906427de..fe40488d8f0110bbfd3ff5cb261f9bde06115d67 100755
--- a/build/android/buildbot/bb_device_status_check.py
+++ b/build/android/buildbot/bb_device_status_check.py
@@ -81,8 +81,10 @@ def DeviceInfo(serial, options):
'']
errors = []
+ dev_good = True
if battery_level < 15:
errors += ['Device critically low in battery. Turning off device.']
+ dev_good = False
if not options.no_provisioning_check:
setup_wizard_disabled = (
device_adb.GetProp('ro.setupwizard.mode') == 'DISABLED')
@@ -103,7 +105,7 @@ def DeviceInfo(serial, options):
logging.error(str(e))
device_adb.old_interface.Shutdown()
full_report = '\n'.join(report)
- return device_type, device_build, battery_level, full_report, errors, True
+ return device_type, device_build, battery_level, full_report, errors, dev_good
def CheckForMissingDevices(options, adb_online_devs):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698