Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/object.cc

Issue 473673004: Avoid UTF-8 decoding in num.toString. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/num.dart ('K') | « runtime/lib/num_patch.dart ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/object.cc
===================================================================
--- runtime/lib/object.cc (revision 39368)
+++ runtime/lib/object.cc (working copy)
@@ -46,6 +46,7 @@
DEFINE_NATIVE_ENTRY(Object_toString, 1) {
const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));
+ ASSERT(!instance.IsString()); // See issue 20583.
const char* c_str = instance.ToCString();
return String::New(c_str);
}
« runtime/lib/num.dart ('K') | « runtime/lib/num_patch.dart ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698