runtime/lib/num.dart - Issue 473673004: Avoid UTF-8 decoding in num.toString.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/num.dart

Issue 473673004: Avoid UTF-8 decoding in num.toString. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 class _Num extends num {
	Ivan Posva 2014/08/19 20:37:18 We should not extend num, if anything at all this We should not extend num, if anything at all this should implement num. In any case this should really be an abstract class. You can also roll the code from the patch into here, as this is not a SDK class and is internal to the VM. koda 2014/08/19 21:15:18 Done. Show quoted text On 2014/08/19 20:37:18, Ivan Posva wrote: > We should not extend num, if anything at all this should implement num. In any > case this should really be an abstract class. You can also roll the code from > the patch into here, as this is not a SDK class and is internal to the VM. Done.
	6

	7 }

OLD	NEW