runtime/lib/num.cc - Issue 473673004: Avoid UTF-8 decoding in num.toString.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/num.cc

Issue 473673004: Avoid UTF-8 decoding in num.toString. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 #include "vm/bootstrap_natives.h"

	6

	7 #include "vm/native_entry.h"

	8 #include "vm/object.h"

	9

	10 namespace dart {

	11

	12 DEFINE_NATIVE_ENTRY(num_toString, 1) {
	Ivan Posva 2014/08/19 20:37:18 Num_toString or Number_toString, depending on the Num_toString or Number_toString, depending on the eventual name of the class. koda 2014/08/19 21:15:18 Done. Show quoted text On 2014/08/19 20:37:18, Ivan Posva wrote: > Num_toString or Number_toString, depending on the eventual name of the class. Done.
	13 const Number& number = Number::CheckedHandle(arguments->NativeArgAt(0));

	14 return number.ToString(Heap::kNew);

	15 }

	16

	17 } // namespace dart

OLD	NEW