Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 47363002: Make intsafe.h workaround global (Closed)

Created:
7 years, 1 month ago by scottmg
Modified:
7 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, sadrul, amit, sievers+watch_chromium.org, ben+aura_chromium.org, dcaiafa+watch_chromium.org, alexeypa+watch_chromium.org, jbauman+watch_chromium.org, kalyank, wez+watch_chromium.org, sanjeevr, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, cc-bugs_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Ian Vollick, tfarina, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, danakj+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Make intsafe.h workaround global This was coming up in a lot of places, so make it a global include (on the express toolchain) and remove the individual occurences of the same pattern. R=wez@chromium.org TBR=sky@chromium.org BUG=308740 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M build/common.gypi View 1 chunk +14 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years, 1 month ago (2013-10-27 03:05:05 UTC) #1
Wez
lgtm
7 years, 1 month ago (2013-10-27 05:17:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/47363002/1
7 years, 1 month ago (2013-10-27 05:17:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=32769
7 years, 1 month ago (2013-10-27 05:34:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/47363002/1
7 years, 1 month ago (2013-10-28 15:58:45 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 19:30:47 UTC) #6
Message was sent while issue was closed.
Change committed as 231378

Powered by Google App Engine
This is Rietveld 408576698