Redesign the home card bottom state.

Redesign the home card bottom state.

This CL also renames the class name to AthenaStartPageView
and I am expecting to use the same view to CENTERED state,
so that we can achieve the smooth state transition meanwhile.

BUG=401570
R=sadrul@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289690

[sadrul, 2014-08-13 22:01:13]

https://codereview.chromium.org/473623002/diff/20001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/473623002/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:109: canvas->DrawPath(path, border_paint);
This is a tiny bit unfortunate: because we have views::Border for painting the
border, and views::Background for painting the background. But we do the same
thing (i.e. paint both from a background) in a few other places too.

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:44: const int kHomeCardMinimizedHeight = 8;
Did you mean to remove this?

The small text in the mock says the blackbar is 6px high, with the white-bar 2px
high, 112px wide, bottom-aligned.

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:285: minimized_view_->SetPaintToLayer(true);
I agree with the comment in the CL description: this would be easier to do with
a single View with different states, instead of having separate main_view_ and
bottom_view_ (|bottom_view_| would have to stay, since it remains in-place, and
fades out when the bottom/main-view comes up.

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:303: minimized_view_->layer()->SetOpacity(1.0f -
progress);
When transitioning MINIMIZED ==> BOTTOM, with progress == 0, shouldn't the
opacity of |minimized_view_| be 0 (i.e. == progress)? (I think the opacity of
bottom_view_ will be = (1 - progress) instead)

[Jun Mukai, 2014-08-13 23:18:23]

https://codereview.chromium.org/473623002/diff/20001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/473623002/diff/20001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:109: canvas->DrawPath(path, border_paint);
On 2014/08/13 22:01:13, sadrul wrote:
> This is a tiny bit unfortunate: because we have views::Border for painting the
> border, and views::Background for painting the background. But we do the same
> thing (i.e. paint both from a background) in a few other places too.

split this into two classes, renamed to be more generic ones, as
RoundedRectBackground and RoundedRectBorder. How is it?

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
File athena/home/home_card_impl.cc (right):

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:44: const int kHomeCardMinimizedHeight = 8;
On 2014/08/13 22:01:13, sadrul wrote:
> Did you mean to remove this?
> 
> The small text in the mock says the blackbar is 6px high, with the white-bar
2px
> high, 112px wide, bottom-aligned.

thanks, removed. Also changed the height to 6px. Let me redesign the blackbar in
another CL.

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:285: minimized_view_->SetPaintToLayer(true);
On 2014/08/13 22:01:13, sadrul wrote:
> I agree with the comment in the CL description: this would be easier to do
with
> a single View with different states, instead of having separate main_view_ and
> bottom_view_ (|bottom_view_| would have to stay, since it remains in-place,
and
> fades out when the bottom/main-view comes up.

Thanks. I think we should keep minimized_view_ as a separate view because it
will overlap with bottom view in the transition.

https://codereview.chromium.org/473623002/diff/20001/athena/home/home_card_im...
athena/home/home_card_impl.cc:303: minimized_view_->layer()->SetOpacity(1.0f -
progress);
On 2014/08/13 22:01:13, sadrul wrote:
> When transitioning MINIMIZED ==> BOTTOM, with progress == 0, shouldn't the
> opacity of |minimized_view_| be 0 (i.e. == progress)? (I think the opacity of
> bottom_view_ will be = (1 - progress) instead)

The progress means how far from |from_state_|, so progress 0 means same as the
|from_state_|, which is MINIMIZED state in this case. So the opacity should be
1.0.

[sadrul, 2014-08-14 03:03:27]

LGTM

https://codereview.chromium.org/473623002/diff/40001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/473623002/diff/40001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:107: class RoundRectBorder : public
views::Border {
Maybe you could use views::RoundRectPainter instead?

https://codereview.chromium.org/473623002/diff/40001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:185:
child_at(0)->SetBoundsRect(container_bounds);
Maybe keep track of |app_icon_container_| (or something similar) instead.

[Jun Mukai, 2014-08-14 16:49:36]

https://codereview.chromium.org/473623002/diff/40001/athena/home/athena_start...
File athena/home/athena_start_page_view.cc (right):

https://codereview.chromium.org/473623002/diff/40001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:107: class RoundRectBorder : public
views::Border {
On 2014/08/14 03:03:27, sadrul wrote:
> Maybe you could use views::RoundRectPainter instead?

Done.

https://codereview.chromium.org/473623002/diff/40001/athena/home/athena_start...
athena/home/athena_start_page_view.cc:185:
child_at(0)->SetBoundsRect(container_bounds);
On 2014/08/14 03:03:27, sadrul wrote:
> Maybe keep track of |app_icon_container_| (or something similar) instead.

Done. Since it also contains the search box, named as |container_|

[Jun Mukai, 2014-08-14 16:49:40]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-08-14 16:54:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/473623002/60001

[commit-bot: I haz the power, 2014-08-14 20:26:18]

Committed patchset #4 (60001) as 289690