Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 473603003: Updates the IME component extension manifests. (Closed)

Created:
6 years, 4 months ago by Shu Chen
Modified:
6 years, 3 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updates the IME component extension manifests. 1) Use hash in inputview url to support fast inputview switching. 2) Add 'm17n:' to m17n keyboard layout id to avoid conflicts (e.g. 'si' in XKB vs. 'si' in M17n) 3) Change layout IDs for Chinese IMEs to support future compact layouts. BUG=254398, 406979 TEST=Verified on linux_chromeos. Committed: https://crrev.com/d650f0046162b99b2eff86edc4689506d04f8748 Cr-Commit-Position: refs/heads/master@{#292863}

Patch Set 1 #

Patch Set 2 : update for pinyin's layout id. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -120 lines) Patch
M chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json View 1 60 chunks +60 lines, -60 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 60 chunks +60 lines, -60 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Seigo Nonaka
lgtm
6 years, 4 months ago (2014-08-25 05:12:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/473603003/20001
6 years, 3 months ago (2014-09-01 11:10:17 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 056ecc5147c48685709b6165c2e2ac395c57422b
6 years, 3 months ago (2014-09-01 12:05:23 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:16:34 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d650f0046162b99b2eff86edc4689506d04f8748
Cr-Commit-Position: refs/heads/master@{#292863}

Powered by Google App Engine
This is Rietveld 408576698