Sort separate Edits in FileEdit during adding.

pkg/analysis_services/lib/correction/change.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.correction.change;
 
 import 'package:analysis_services/constants.dart';
 import 'package:analysis_services/json.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:collection/collection.dart';
@@ skipping 70 matching lines @@
       EDITS: objectToJson(fileEdits),
       LINKED_EDIT_GROUPS: objectToJson(linkedEditGroups)
     };
     if (selection != null) {
       json[SELECTION] = selection.toJson();
     }
     return json;
   }
 
   @override
-  String toString() => 'Change(message=$message, edits=$fileEdits, '
-      'linkedEditGroups=$linkedEditGroups, selection=$selection)';
+  String toString() =>
+      'Change(message=$message, edits=$fileEdits, '
+          'linkedEditGroups=$linkedEditGroups, selection=$selection)';
 }
 
 
 /**
  * A description of a single change to a single file. 
  */
 class Edit implements HasToJson {
   /**
    * The offset of the region to be modified. 
    */
   final int offset;
 
   /**
    * The length of the region to be modified.
    */
   final int length;
 
   /**
    * The text that is to replace the specified region in the original text. 
    */
   final String replacement;
 
   Edit(this.offset, this.length, this.replacement);
 
-  Edit.range(SourceRange range, String replacement) : this(range.offset,
-      range.length, replacement);
+  Edit.range(SourceRange range, String replacement) : this(
+      range.offset,
+      range.length,
+      replacement);
 
   /**
    * The offset of a character immediately after the region to be modified. 
    */
   int get end => offset + length;
 
   bool operator ==(other) {
     if (other is Edit) {
-      return other.offset == offset && other.length == length &&
+      return other.offset == offset &&
+          other.length == length &&
           other.replacement == replacement;
     }
     return false;
   }
 
+  /**
+   * Get the result of applying the edit to the given [code].
+   */
+  String apply(String code) {
+    return code.substring(0, offset) + replacement + code.substring(end);
+  }
+
   @override
   Map<String, Object> toJson() {
     return {
       OFFSET: offset,
       LENGTH: length,
       REPLACEMENT: replacement
     };
   }
 
   @override
   String toString() =>
       "Edit(offset=$offset, length=$length, replacement=:>$replacement<:)";
 
   /**
-   * Get the result of applying the edit to the given [code].
-   */
-  String apply(String code) => code.substring(0, offset) + replacement +
-      code.substring(end);
-
-  /**
    * Get the result of applying a set of [edits] to the given [code].  Edits
    * are applied in the order they appear in [edits].
    */
   static String applySequence(String code, Iterable<Edit> edits) {
     edits.forEach((Edit edit) {
       code = edit.apply(code);
     });
     return code;
   }
-
-  /**
-   * Get the result of applying a set of [edits] to the given [code].  Edits
-   * are applied in the order of decreasing offset.
-   */
-  static String applySorted(String code, Iterable<Edit> edits) {
-    List<Edit> sortedEdits = edits.toList();
-    mergeSort(sortedEdits, compare: (a, b) => a.offset - b.offset);
-    return Edit.applySequence(code, sortedEdits.reversed);
-  }
 }
 
 
 /**
- * A description of a set of changes to a single file. 
+ * A description of a set of changes to a single file.
+ *
+ * [Edit]s are added in the order of decreasing offset, so they are easy to
+ * apply to the original file content without correcting offsets.
  */
 class FileEdit implements HasToJson {
   /**
    * The file to be modified.
    */
   final String file;
 
   /**
    * A list of the [Edit]s used to effect the change. 
    */
   final List<Edit> edits = <Edit>[];
 
   FileEdit(this.file);
 
   /**
    * Adds the given [Edit] to the list.
    */
   void add(Edit edit) {
-    edits.add(edit);
+    int index = 0;
+    while (index < edits.length && edits[index].offset > edit.offset) {
+      index++;
+    }
+    edits.insert(index, edit);
+  }
+
+  /**
+   * Adds the given [Edit]s.
+   */
+  void addAll(Iterable<Edit> edits) {
+    edits.forEach(add);
   }
 
   @override
   Map<String, Object> toJson() {
     return {
       FILE: file,
       EDITS: objectToJson(edits)
     };
   }
 
@@ skipping 28 matching lines @@
   Map<String, Object> toJson() {
     return {
       ID: id,
       LENGTH: length,
       POSITIONS: objectToJson(positions),
       SUGGESTIONS: objectToJson(suggestions)
     };
   }
 
   @override
-  String toString() => 'LinkedEditGroup(id=$id, length=$length, '
-      'positions=$positions, suggestions=$suggestions)';
+  String toString() =>
+      'LinkedEditGroup(id=$id, length=$length, '
+          'positions=$positions, suggestions=$suggestions)';
 }
 
 
 /**
  * A suggestion of a value that could be used to replace all of the linked edit
  * regions in a [LinkedEditGroup].
  */
 class LinkedEditSuggestion implements HasToJson {
   final LinkedEditSuggestionKind kind;
   final String value;
@@ skipping 63 matching lines @@
   Map<String, Object> toJson() {
     return {
       FILE: file,
       OFFSET: offset
     };
   }
 
   @override
   String toString() => 'Position(file=$file, offset=$offset)';
 }