Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473553003: DevTools: Process correctly a disconnection during target initialization (Closed)

Created:
6 years, 4 months ago by sergeyv
Modified:
6 years, 4 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Process correctly a disconnection during target initialization BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180475

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 4 chunks +11 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerTargetManager.js View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 13 (0 generated)
sergeyv
6 years, 4 months ago (2014-08-18 12:46:43 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/473553003/diff/1/Source/devtools/front_end/sdk/WorkerTargetManager.js File Source/devtools/front_end/sdk/WorkerTargetManager.js (right): https://chromiumcodereview.appspot.com/473553003/diff/1/Source/devtools/front_end/sdk/WorkerTargetManager.js#newcode53 Source/devtools/front_end/sdk/WorkerTargetManager.js:53: if (target && data.inspectorConnected) Would you mind renaming ...
6 years, 4 months ago (2014-08-18 13:46:55 UTC) #2
sergeyv
https://codereview.chromium.org/473553003/diff/1/Source/devtools/front_end/sdk/WorkerTargetManager.js File Source/devtools/front_end/sdk/WorkerTargetManager.js (right): https://codereview.chromium.org/473553003/diff/1/Source/devtools/front_end/sdk/WorkerTargetManager.js#newcode53 Source/devtools/front_end/sdk/WorkerTargetManager.js:53: if (target && data.inspectorConnected) On 2014/08/18 13:46:55, vsevik wrote: ...
6 years, 4 months ago (2014-08-18 13:49:15 UTC) #3
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-18 13:49:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/473553003/1
6 years, 4 months ago (2014-08-18 13:50:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 14:55:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 16:01:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23250)
6 years, 4 months ago (2014-08-18 16:01:51 UTC) #8
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-18 17:01:41 UTC) #9
sergeyv
The CQ bit was unchecked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-18 17:01:41 UTC) #10
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 4 months ago (2014-08-18 17:01:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/473553003/1
6 years, 4 months ago (2014-08-18 17:02:23 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 17:03:00 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180475

Powered by Google App Engine
This is Rietveld 408576698