Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 473553002: Add a button to Print Preivew to open printer's Advanced options dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index e375840d814fec9385617347dbdc876fd483449d..5d43e211e03b06547efc591f6b8772f2f88e4497 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -159,6 +159,15 @@ cr.define('print_preview', function() {
this.addChild(this.otherOptionsSettings_);
/**
+ * Component that renders the advanced options button.
+ * @type {!print_preview.AdvancedOptionsSettings}
+ * @private
+ */
+ this.advancedOptionsSettings_ = new print_preview.AdvancedOptionsSettings(
+ this.destinationStore_);
+ this.addChild(this.advancedOptionsSettings_);
+
+ /**
* Component used to search for print destinations.
* @type {!print_preview.AdvancedSettings}
* @private
@@ -383,6 +392,11 @@ cr.define('print_preview', function() {
print_preview.DestinationListItem.EventType.REGISTER_PROMO_CLICKED,
this.onCloudPrintRegisterPromoClick_.bind(this));
+ this.tracker.add(
+ this.advancedOptionsSettings_,
+ print_preview.AdvancedOptionsSettings.EventType.BUTTON_ACTIVATED,
+ this.onAdvancedOptionsButtonActivated_.bind(this));
+
// TODO(rltoscano): Move no-destinations-promo into its own component
// instead being part of PrintPreview.
this.tracker.add(
@@ -411,6 +425,7 @@ cr.define('print_preview', function() {
this.colorSettings_.decorate($('color-settings'));
this.marginSettings_.decorate($('margin-settings'));
this.otherOptionsSettings_.decorate($('other-options-settings'));
+ this.advancedOptionsSettings_.decorate($('advanced-options-settings'));
this.advancedSettings_.decorate($('advanced-settings'));
this.previewArea_.decorate($('preview-area'));
@@ -436,6 +451,7 @@ cr.define('print_preview', function() {
this.colorSettings_.isEnabled = isEnabled;
this.marginSettings_.isEnabled = isEnabled;
this.otherOptionsSettings_.isEnabled = isEnabled;
+ this.advancedOptionsSettings_.isEnabled = isEnabled;
},
/**
@@ -851,6 +867,16 @@ cr.define('print_preview', function() {
},
/**
+ * Called when the destination settings' change button is activated.
+ * Displays the destination search component.
+ * @private
+ */
+ onAdvancedOptionsButtonActivated_: function() {
+ this.advancedSettings_.showForDestination(
+ this.destinationStore_.selectedDestination);
+ },
+
+ /**
* Called when the destination search dispatches manage cloud destinations
* event. Calls corresponding native layer method.
* @private
@@ -1172,6 +1198,7 @@ cr.define('print_preview', function() {
<include src="settings/margin_settings.js"/>
<include src="settings/destination_settings.js"/>
<include src="settings/other_options_settings.js"/>
+<include src="settings/advanced_options_settings.js"/>
<include src="settings/advanced_settings/advanced_settings.js"/>
<include src="settings/advanced_settings/advanced_settings_item.js"/>

Powered by Google App Engine
This is Rietveld 408576698