Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 473553002: Add a button to Print Preivew to open printer's Advanced options dialog. (Closed)

Created:
6 years, 4 months ago by Aleksey Shlyapnikov
Modified:
6 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add a button to Print Preivew to open printer's Advanced options dialog. BUG=397741 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289655

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address cl comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 6 chunks +27 lines, -0 lines 0 comments Download
A + chrome/browser/resources/print_preview/settings/advanced_options_settings.css View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/print_preview/settings/advanced_options_settings.html View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/advanced_options_settings.js View 1 1 chunk +94 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Aleksey Shlyapnikov
6 years, 4 months ago (2014-08-13 18:13:42 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/473553002/diff/1/chrome/browser/resources/print_preview/settings/advanced_options_settings.css File chrome/browser/resources/print_preview/settings/advanced_options_settings.css (right): https://codereview.chromium.org/473553002/diff/1/chrome/browser/resources/print_preview/settings/advanced_options_settings.css#newcode1 chrome/browser/resources/print_preview/settings/advanced_options_settings.css:1: /* Copyright (c) 2014 The Chromium Authors. All ...
6 years, 4 months ago (2014-08-13 18:21:20 UTC) #2
Aleksey Shlyapnikov
https://codereview.chromium.org/473553002/diff/1/chrome/browser/resources/print_preview/settings/advanced_options_settings.css File chrome/browser/resources/print_preview/settings/advanced_options_settings.css (right): https://codereview.chromium.org/473553002/diff/1/chrome/browser/resources/print_preview/settings/advanced_options_settings.css#newcode1 chrome/browser/resources/print_preview/settings/advanced_options_settings.css:1: /* Copyright (c) 2014 The Chromium Authors. All rights ...
6 years, 4 months ago (2014-08-13 18:35:44 UTC) #3
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 4 months ago (2014-08-13 18:35:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/473553002/20001
6 years, 4 months ago (2014-08-13 18:37:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 06:53:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 12:55:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/5677)
6 years, 4 months ago (2014-08-14 12:55:33 UTC) #8
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 4 months ago (2014-08-14 18:03:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/473553002/20001
6 years, 4 months ago (2014-08-14 18:05:13 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 18:50:54 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289655

Powered by Google App Engine
This is Rietveld 408576698