Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 47353005: Cleanup: Remove an unnecessary AutocompleteMatch& calculation (Closed)

Created:
7 years, 1 month ago by Peter Kasting
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove an unnecessary AutocompleteMatch& calculation from OmniboxEditModel::OpenMatch(). I traced the origin of this weird code back to the days before OpenMatch() took an AutocompleteMatch; back then, we constructed one so we could get at fields like |fill_into_edit| that weren't provided to OpenMatch(). Now that we pass this in, I believe the calculated match should always match the passed-in match. BUG=none TEST=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232847

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
7 years, 1 month ago (2013-11-01 02:20:10 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-01 18:31:47 UTC) #2
Peter Kasting
FYI, I had to revert the "dynamically calculate ShortcutsBackend" code, because it doesn't work when ...
7 years, 1 month ago (2013-11-04 23:20:23 UTC) #3
Peter Kasting
7 years, 1 month ago (2013-11-05 00:21:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r232847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698