net/proxy/proxy_service.h - Issue 473513002: Keep track of network error in ProxyRetryInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_service.h

Issue 473513002: Keep track of network error in ProxyRetryInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor formatting. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_service.h

diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h

index 7b3e5d26491e387242075b0fa478e44a28169760..9de86a70bf68430be927a5682f9a304d5c8b379f 100644

--- a/net/proxy/proxy_service.h

+++ b/net/proxy/proxy_service.h

@@ -169,7 +169,8 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,

// Called to report that the last proxy connection succeeded. If |proxy_info|

// has a non empty proxy_retry_info map, the proxies that have been tried (and

// failed) for this request will be marked as bad.

- void ReportSuccess(const ProxyInfo& proxy_info);

+ void ReportSuccess(const ProxyInfo& proxy_info,

+ NetworkDelegate* network_delegate);

// Call this method with a non-null |pac_request| to cancel the PAC request.

void CancelPacRequest(PacRequest* pac_request);