google_apis/gcm/engine/connection_factory_impl.cc - Issue 473513002: Keep track of network error in ProxyRetryInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl.cc

Issue 473513002: Keep track of network error in ProxyRetryInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor formatting Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/connection_factory_impl.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc

index cf90aed89c3161dc250bf4f93b56c5a78cbe349b..4963f1327109581ad817ae6a7bd91a784eb06f51 100644

--- a/google_apis/gcm/engine/connection_factory_impl.cc

+++ b/google_apis/gcm/engine/connection_factory_impl.cc

@@ -536,7 +536,7 @@ int ConnectionFactoryImpl::ReconsiderProxyAfterError(int error) {

void ConnectionFactoryImpl::ReportSuccessfulProxyConnection() {

if (gcm_network_session_ && gcm_network_session_->proxy_service())

- gcm_network_session_->proxy_service()->ReportSuccess(proxy_info_);

+ gcm_network_session_->proxy_service()->ReportSuccess(proxy_info_, NULL);

}

void ConnectionFactoryImpl::CloseSocket() {